Class names in cats.tests are not consistent.
#1965
Labels
Comments
|
I can help with this. Should |
|
@AlejandroME, thanks so much! Yeah I incline to use |
|
Got it! Working on it @kailuowang |
AlejandroME
added a commit
to AlejandroME/cats
that referenced
this issue
Oct 16, 2017
- Renames tests in `cats.tests` package with the "Suite" suffix, according to typelevel#1960 and typelevel#1965.
kailuowang
pushed a commit
that referenced
this issue
Oct 19, 2017
* Unifies tests naming standard - Renames tests in `cats.tests` package with the "Suite" suffix, according to #1960 and #1965. * Removes laws import aliases * Deletes more import alias - The previous commit resolved some conflicting files. Also, test classes in `cats.jvm` and `cats.free` packages were renamed to use the `XXXXSuite` naming convention. - Deleted some import aliases to `cats.kernel.laws.discipline` classes
kailuowang
pushed a commit
to kailuowang/cats
that referenced
this issue
Oct 23, 2017
* Unifies tests naming standard - Renames tests in `cats.tests` package with the "Suite" suffix, according to typelevel#1960 and typelevel#1965. * Removes laws import aliases * Deletes more import alias - The previous commit resolved some conflicting files. Also, test classes in `cats.jvm` and `cats.free` packages were renamed to use the `XXXXSuite` naming convention. - Deleted some import aliases to `cats.kernel.laws.discipline` classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The majority is named
XXXXTestswhich causes some conflicts withcats.laws.discipline.XXXXTests(discussed in #1960)Other forms includes
XXXXCheckXXXXTestXXXXSuiteWe should consolidate them all to a single naming scheme.
XXXXSuitemaybe a good option.The text was updated successfully, but these errors were encountered: