Unifies test naming standard

[AlejandroME]

Fixes #1965.

@kailuowang There are other tests in packages like cats.jvm.tests and cats.free that wasn't renamed. Should I have to rename them also?

[kailuowang]

Thanks a lot!
With these renames, import renames like
import cats.kernel.laws.discipline.{MonoidTests => MonoidLawTests}
will no longer be needed. Will you kindly update them as well?

[codecov-io]

Codecov Report

Merging #1975 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1975   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files         272      272           
  Lines        4628     4628           
  Branches      124      124           
=======================================
  Hits         4453     4453           
  Misses        175      175

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a162dd...6a65551. Read the comment docs.

[AlejandroME]

@kailuowang Only for clarifying, do you mean:

1. Rename tests in cats.jvm.tests and cats.free as well.
2. Remove the import aliases and use the test name normally

If so, I'll do it ending the day :)

Please let me know

[kailuowang]

@AlejandroME yeah, sorry I wasn't clear. Thanks!

[AlejandroME]

@kailuowang I'm almost done, but I have a question. The import aliases that you've mentioned (import cats.kernel.laws.discipline.{MonoidTests => MonoidLawTests}) are pointing to a package that is not contained in test, but all the classes are named with the prefix Test (like the aforementioned one). Should I make the change (rename to XXXXSuite) in that package also? (cats.kernel.laws.discipline).

I ask this question because I'm not sure about the nature of these classes because I don't see them as tests, but classes that help laws checking.

Sorry if it is a newbie question, but I prefer to ask before doing something dangerous.

Thanks!

[kailuowang]

@AlejandroME no it's totally my fault, I was completely blind over the fact that you are new to this part of the code base.

Before your PR, there are two XXXXTests for many XXXXs, one in cats.test and one in cats.laws or cats.kernel.laws. The import aliases were to avoid the conflicts between them. Now that you renamed the ones in cats.tests, we no longer need those import aliases. For example, if a file in cats.tests has

import cats.kernel.laws.discipline.{MonoidTests => MonoidLawTests}

and later on referred to MonoidLawTests, it was because there was a MonoidTests in cats.tests as well.

Now with your changes, we can remove the import alias and just use MonoidTests in the file.
Would this make sense?
Sorry again about the confusion.

[AlejandroME]

@kailuowang No worries, and thank you for the clarification!
Sure, hope to finish this today!

[kailuowang]

oh sorry, I forgot to mention that we should rename tests in cats.jvm.tests and cats.free as well.

[AlejandroME]

@kailuowang No worries, I'm resolving the conflicting files and then I proceed to rename those files :)

[AlejandroME]

@kailuowang I think that it's done. The tests are running ok on my machine.
Waiting for the Travis result and your review :)