Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix many cats-kernel instances. #1324

Merged
merged 7 commits into from
Aug 24, 2016
Merged

Fix many cats-kernel instances. #1324

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
706effc
Fix many cats-kernel instances.
erik-stripe Aug 23, 2016
aeee001
Check BitSet instances (and Set's semilattice).
erik-stripe Aug 23, 2016
e2e0996
Replace Either#fold with pattern match in instances.
erik-stripe Aug 23, 2016
cffe60f
Fix type mismatch.
erik-stripe Aug 23, 2016
db2eab3
Add Semigroup[Either[A, B]] and save some allocations.
erik-stripe Aug 23, 2016
2d3b474
One last allocation.
erik-stripe Aug 23, 2016
24e4de2
Fewer allocations (and fix type error).
erik-stripe Aug 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/cats/instances/either.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ trait EitherInstances extends cats.kernel.instances.EitherInstances {

def traverse[F[_], B, C](fa: Either[A, B])(f: B => F[C])(implicit F: Applicative[F]): F[Either[A, C]] =
fa match {
case left @ Left(_) => F.pure(left)
case Left(a) => F.pure(Left(a))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe: https://github.com/typelevel/cats/blob/master/core/src/main/scala/cats/syntax/either.scala#L301

case left @ Left(_) => F.pure(left.rightCast[C])

save an allocation?

case Right(b) => F.map(f(b))(Right(_))
}

Expand Down