Add regexes for Edge Chromium on iOS and Android #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
|
Yes you are right the regexes are duplicated now. Thanks for highlighting. Will revert the change. |
commenthol
added a commit
to commenthol/uap-core
that referenced
this pull request
Apr 18, 2020
|
Sorry about the duplicate pull request. I forgot to re-fork and #451 didn't exist in my old fork, and I saw the open Issue so I thought it hadn't been addressed. |
commenthol
added a commit
that referenced
this pull request
Apr 19, 2020
fix(#473): EdgeMobile simplify and remove duplicated rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge Chromium on iOS and Android have new user agents. Added a regex that handles them so they are detected properly as Edge Mobile.
Fixes #328