Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regexes for Edge Chromium on iOS and Android #473

Merged
merged 1 commit into from
Apr 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions regexes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,10 @@ user_agent_parsers:
- regex: 'Windows Phone .*(Edge)/(\d+)\.(\d+)'
family_replacement: 'Edge Mobile'

# Edge Mobile (Chromium)
- regex: '(EdgiOS|EdgA)/(\d+)\.(\d+)\.(\d+)\.(\d+)'
family_replacement: 'Edge Mobile'

# Samsung Internet (based on Chrome, but lacking some features)
- regex: '(SamsungBrowser)/(\d+)\.(\d+)'
family_replacement: 'Samsung Internet'
Expand Down
12 changes: 12 additions & 0 deletions tests/test_ua.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6831,6 +6831,18 @@ test_cases:
minor: '0'
patch:

- user_agent_string: 'Mozilla/5.0 (iPhone; CPU iPhone OS 12_3_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.1.1 EdgiOS/44.5.0.10 Mobile/15E148 Safari/604.1'
family: 'Edge Mobile'
major: '44'
minor: '5'
patch: '0'

- user_agent_string: 'Mozilla/5.0 (Linux; Android 8.1.0; Pixel Build/OPM4.171019.021.D1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.109 Mobile Safari/537.36 EdgA/42.0.0.2057'
family: 'Edge Mobile'
major: '42'
minor: '0'
patch: '0'

- user_agent_string: 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/537.36 (KHTML, like Gecko) brave/0.7.11 Chrome/47.0.2526.110 Brave/0.36.5 Safari/537.36'
family: 'Brave'
major: '0'
Expand Down