Track container events, reworked Deployment management #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potential fix for `npm ERR! Maximum call stack size exceeded` in Travis builds: npm/npm#17056
Reverts most of the changes for <-chan error
… daemon/#161-container-failures
bobheadxi
force-pushed
the
daemon/#161-container-failures
branch
from
0e112c4
to
cb721ff
Compare
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
+ Coverage 40.16% 43.78% +3.63%
==========================================
Files 57 58 +1
Lines 3230 3287 +57
==========================================
+ Hits 1297 1439 +142
+ Misses 1779 1663 -116
- Partials 154 185 +31
Continue to review full report at Codecov.
|
bobheadxi
force-pushed
the
daemon/#161-container-failures
branch
from
b213982
to
98b8d33
Compare
Forgot to add `for` to loop perpetually
bobheadxi
added
pr: finalized
bwdmonkey
reviewed
Jul 29, 2018
daemon/inertiad/build/builder.go
Outdated
| return nil, errors.New("Build exited with non-zero status: " + strconv.FormatInt(status, 10)) | ||
| if status.StatusCode != 0 { | ||
| return nil, fmt.Errorf( | ||
| "Build exited with non-zero status %s", strconv.FormatInt(status.StatusCode, 10)) |
There was a problem hiding this comment.
Couldn't we just straight pass it into instead of casting?
bwdmonkey
reviewed
Jul 29, 2018
daemon/inertiad/build/builder.go
Outdated
| close(stop) | ||
| if err != nil { | ||
| return nil, err | ||
| statusCh, errCh := cli.ContainerWait(ctx, resp.ID, "") |
There was a problem hiding this comment.
Seems like a bit of duplicate code is here. I think it would be nice to have a helper function instead.
bwdmonkey
reviewed
Jul 29, 2018
daemon/inertiad/daemon.go
Outdated
| "github.com/ubclaunchpad/inertia/daemon/inertiad/crypto" | ||
| "github.com/ubclaunchpad/inertia/daemon/inertiad/project" | ||
| ) | ||
|
|
||
| const ( | ||
| msgNoDeployment = "No deployment is currently active on this remote - try running 'inertia $REMOTE up'" |
There was a problem hiding this comment.
Standardization please. [remote]
bwdmonkey
reviewed
Jul 29, 2018
| } | ||
| defer cli.Close() | ||
|
|
||
| if status, _ := deployment.GetStatus(cli); len(status.Containers) == 0 { |
| }, | ||
| logger, | ||
| ) | ||
| if err != nil { | ||
| logger.WriteErr(err.Error(), http.StatusPreconditionFailed) | ||
| return | ||
| } | ||
| deployment = d |
bobheadxi
force-pushed
the
daemon/#161-container-failures
branch
from
14add4e
to
2bdc799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): Closes #161, improves #237, closes #323
👷 Changes
🔦 Testing Instructions
You should get: