Add warning that GitHub webhook Content-Type must be JSON #445
Conversation
client/client.go
Outdated
| @@ -122,6 +122,9 @@ func (c *Client) BootstrapRemote(repoName string) error { | |||
| fmt.Fprint(c.out, "\n"+`Note that you will have to disable SSH verification in your webhook | |||
| settings - Inertia uses self-signed certificates that GitHub won't | |||
| be able to verify.`+"\n") | |||
| fmt.Fprint(c.out, "\n"+`Note that you will have to set the Content-Type for your webhook | |||
There was a problem hiding this comment.
why not put this together with the previous note?
There was a problem hiding this comment.
No particular reason, though I imagine those two lines might be changed independently in the future, so it's worth having two separate messages - on the other hand I can see the argument that it's worth putting them together so people actually read both.
There was a problem hiding this comment.
thats fair, though for the sake of smoothness maybe Note that you will *also* have to set... would flow better 😋
Also linters are complaining about spacing 😢
https://travis-ci.org/ubclaunchpad/inertia/jobs/452143344#L527
There was a problem hiding this comment.
Yeah, that's fair, can update
There was a problem hiding this comment.
There was a problem hiding this comment.
This makes me extremely sad. 😞
But I can fix it.
rwblickhan
force-pushed
the
rwblickhan/#444-no-notification-of-json-github-webhook
branch
from
9317cd7
to
994db75
Compare
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
==========================================
+ Coverage 45.2% 45.24% +0.05%
==========================================
Files 67 67
Lines 3525 3528 +3
==========================================
+ Hits 1593 1596 +3
Misses 1747 1747
Partials 185 185
Continue to review full report at Codecov.
|
…claunchpad#445)" This reverts commit c3ed6e2.
🎟️ Ticket(s): Closes #444
👷 Changes
Adds a brief warning that Content-Type for GitHub webhook must be JSON after providing it.