daemon: added support for github form-encoded webhooks #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
==========================================
+ Coverage 56.09% 56.22% +0.14%
==========================================
Files 60 60
Lines 2951 2983 +32
==========================================
+ Hits 1655 1677 +22
- Misses 1089 1098 +9
- Partials 207 208 +1
Continue to review full report at Codecov.
|
bobheadxi
requested changes
Feb 5, 2019
There was a problem hiding this comment.
This is terrific, thanks @didil !
Just a few changes before we can merge this:
- can you remove the changes to
.static? I notice that there's something weird going on with the images for some people, but I'd rather it be resolved in a separate PR - I notice you've changed the permissions on
test/keys/id_rsafrom 755 to 644 - it was recently changed to 755 in 5a0414e, since one of our members (@mRabitsky ) was having issues with his SSH client saying that the permissions on the key were too open. Did the key not work for you as-is? If it did, can you revert the change? If it did not, can you revert the change anyway? I'll open up a ticket to look into how to resolve this long-term
Thank you!
bobheadxi
requested review from
rwblickhan,
seifghazi,
terryz21,
nicholaschinjie and
yaoharry
terryz21
previously approved these changes
Feb 5, 2019
seifghazi
reviewed
Feb 5, 2019
daemon/inertiad/webhook/github.go
Outdated
| case "application/json": | ||
| return body, nil | ||
| default: | ||
| return nil, errors.New("Github Webhook Content-Type must be application/json or x-www-form-urlencoded") |
There was a problem hiding this comment.
"Github webhook Content-Type must be application/json or application/x-www-form-urlencoded" π
nicholaschinjie
previously approved these changes
Feb 5, 2019
didil
dismissed stale reviews from nicholaschinjie, seifghazi, and terryz21
via
09ca84c
|
changes pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ποΈ Ticket(s): Closes #369
π· Changes
Added content-type application/x-www-form-urlencoded support for github
github request form body:
payload={the-same-json-payload-from-json-requests}
π¦ Testing Instructions
make tests
local daemon and test project / webhooks