-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: check for errors on log websockets #533
cmd: check for errors on log websockets #533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks! Just one minor comment
Codecov Report
@@ Coverage Diff @@
## master #533 +/- ##
==========================================
+ Coverage 56.22% 56.25% +0.03%
==========================================
Files 60 60
Lines 2983 2985 +2
==========================================
+ Hits 1677 1679 +2
Misses 1098 1098
Partials 208 208
Continue to review full report at Codecov.
|
Co-Authored-By: didil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank! π
@didil looks like Windows returns a different error when the websocket connection fails:
unfortunately I can't seem to get Appveyor to trigger on our end for forked repositories, so a Windows test run was never made for this PR, and the one for |
ποΈ Ticket(s): Closes #526
π· Changes
add error checking on client.LogsWebSocket + test
π¦ Testing Instructions
make test