Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix log websocket test #534

Merged
merged 2 commits into from
Feb 7, 2019
Merged

fix log websocket test #534

merged 2 commits into from
Feb 7, 2019

Conversation

didil
Copy link
Contributor

@didil didil commented Feb 7, 2019

🎟️ Ticket(s): Closes #526

👷 Changes

fix #533 (comment)

🔦 Testing Instructions

make test

@didil didil requested a review from bobheadxi as a code owner February 7, 2019 05:01
@codecov
Copy link

codecov bot commented Feb 7, 2019 •
edited
Loading

Codecov Report

Merging #534 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   56.25%   56.25%           
=======================================
  Files          60       60           
  Lines        2985     2985           
=======================================
  Hits         1679     1679           
  Misses       1098     1098           
  Partials      208      208

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 026ecae...4c9fcd1. Read the comment docs.

bobheadxi
bobheadxi approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@bobheadxi bobheadxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like appveyor is finally doing its thing - it should pass, hopefully. thanks!

@bobheadxi bobheadxi merged commit e600916 into ubclaunchpad:master Feb 7, 2019
@bobheadxi bobheadxi added the pr: finalized needs review and final approval label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobheadxi bobheadxi bobheadxi approved these changes

Assignees
No one assigned
Labels
pr: finalized needs review and final approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Websocket segfaults when no internet connection
2 participants
@didil @bobheadxi