Report Tag cache size as part of internal metrics #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
+ Coverage 47.46% 47.78% +0.32%
==========================================
Files 64 64
Lines 5948 5985 +37
==========================================
+ Hits 2823 2860 +37
Misses 2685 2685
Partials 440 440
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mway
reviewed
Nov 17, 2022
There was a problem hiding this comment.
General note: the tag count is not the same as cardinality; to get a correct cardinality count you will need to count every root+subscope's metrics.
If we just use the number of tag sets, it misses the (variable) coefficient of how many metrics use each of them.
* increment version * Use bucketed subscope (uber-go#184) * remove unused function Co-authored-by: Cristian Velazquez <[email protected]>
SokolAndrey
reviewed
Jan 6, 2023
brawndou
requested review from
mway and
SokolAndrey
and removed request for
SokolAndrey
SokolAndrey
approved these changes
Jan 10, 2023
brawndou
added a commit
to brawndou/tally
that referenced
this pull request
Jan 14, 2023
Additional internal metrics will be emitted: - `tally.internal.num-tag-cache` will report the number of tags - `tally.internal.counter-cardinality` will report the number of counters across all scopes - `tally.internal.gauge-cardinality` will report the number of gauges across all scopes - `tally.internal.histogram-cardinality` will report the number of histograms across all scopes Other changes: - refactored tests to use internal metric counts defined in variables
brawndou
added a commit
that referenced
this pull request
Jan 14, 2023
Additional internal metrics will be emitted: - `tally.internal.num-tag-cache` will report the number of tags - `tally.internal.counter-cardinality` will report the number of counters across all scopes - `tally.internal.gauge-cardinality` will report the number of gauges across all scopes - `tally.internal.histogram-cardinality` will report the number of histograms across all scopes Other changes: - refactored tests to use internal metric counts defined in variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps service owners know if they are causing Tally to use too much memory