Report Tag cache size as part of internal metrics (#189) #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional internal metrics will be emitted: - `tally.internal.num-tag-cache` will report the number of tags - `tally.internal.counter-cardinality` will report the number of counters across all scopes - `tally.internal.gauge-cardinality` will report the number of gauges across all scopes - `tally.internal.histogram-cardinality` will report the number of histograms across all scopes Other changes: - refactored tests to use internal metric counts defined in variables
|
backporting #189 to v3 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional internal metrics will be emitted:
tally.internal.num-tag-cachewill report the number of tagstally.internal.counter-cardinalitywill report the number of counters across all scopestally.internal.gauge-cardinalitywill report the number of gauges across all scopestally.internal.histogram-cardinalitywill report the number of histograms across all scopesOther changes: