zapslog: Handler should ignore an empty Attr #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the slog.Handler contract, handlers should not log attributes that are equal to the zero value. This is equivalent to Zap's `zap.Skip()`. Discovered by uber-go#1335 Refs uber-go#1334
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #1344 +/- ##
==========================================
+ Coverage 97.77% 97.80% +0.03%
==========================================
Files 51 51
Lines 3366 3369 +3
==========================================
+ Hits 3291 3295 +4
+ Misses 65 63 -2
- Partials 10 11 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
prashantv
added a commit
to prashantv/zap
that referenced
this pull request
Sep 9, 2023
Follow-up to uber-go#1344 to handle empty attributes using a skip field in a single place, so each caller of `convertAttrToField` doesn't have to check for empty attributes explicitly.
abhinav
pushed a commit
that referenced
this pull request
Sep 9, 2023
Follow-up to #1344 to handle empty attributes using a skip field in a single place, so each caller of `convertAttrToField` doesn't have to check for empty attributes explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the slog.Handler contract,
handlers should not log attributes that are equal to the zero value.
This is equivalent to Zap's
zap.Skip().Discovered by #1335
Refs #1334