Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zapslog: Handler should ignore an empty Attr #1344

Merged
merged 1 commit into from
Sep 1, 2023
Merged

zapslog: Handler should ignore an empty Attr #1344

merged 1 commit into from
Sep 1, 2023

Commits on Sep 1, 2023

  1. zapslog: Handler should ignore an empty Attr 

    Per the slog.Handler contract,
handlers should not log attributes that are equal to the zero value.
This is equivalent to Zap's `zap.Skip()`.

Discovered by uber-go#1335
Refs uber-go#1334
    @abhinav
    abhinav committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    910c4cd View commit details
    Browse the repository at this point in the history