Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variables with scope #697

Merged
merged 88 commits into from
Jun 21, 2024

Conversation

fhebel
Copy link
Contributor

@fhebel fhebel commented Jun 11, 2024

At the moment it's only supported to read ci/cd-variables with scope, now they can be created, updated and deleted ...

fhebel and others added 30 commits May 8, 2024 17:19
- Renaming an environment by using the API was deprecated in GitLab 15.9.
- Renaming an environment with the API removed in GitLab 16.0.
          'gitlab/gitlab-ee:16.6.2-ee.0'
          'gitlab/gitlab-ee:16.11.1-ee.0'
@fhebel fhebel requested a review from a team as a code owner June 11, 2024 18:35
@fhebel fhebel requested review from louis-z and removed request for a team June 11, 2024 18:35
NGitLab/Models/Variable.cs Outdated Show resolved Hide resolved
NGitLab/Models/Variable.cs Outdated Show resolved Hide resolved
NGitLab/Models/Variable.cs Outdated Show resolved Hide resolved
NGitLab/Impl/VariableClient.cs Outdated Show resolved Hide resolved
NGitLab/Impl/GroupVariableClient.cs Outdated Show resolved Hide resolved
NGitLab.Tests/ProjectVariableClientTests.cs Outdated Show resolved Hide resolved
NGitLab/Extensions/VariableExtensions.cs Outdated Show resolved Hide resolved
NGitLab/Impl/VariableClient.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@Toa741 Toa741 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the points stating that it's a breaking change: at the moment we try to avoid them.

We have an internal list of the breaking changes that would be neat to add in a further major version. Fields to properties and cleaning old or obsolete props and methods as well.

NGitLab/IProjectBadgeClient.cs Outdated Show resolved Hide resolved
NGitLab/Impl/VariableClient.cs Outdated Show resolved Hide resolved
NGitLab/Models/Variable.cs Show resolved Hide resolved
NGitLab/IProjectBadgeClient.cs Outdated Show resolved Hide resolved
NGitLab/Models/VariableCreate.cs Outdated Show resolved Hide resolved
NGitLab/Models/VariableUpdate.cs Outdated Show resolved Hide resolved
@Toa741 Toa741 merged commit 592170d into ubisoft:main Jun 21, 2024
6 checks passed
@fhebel
Copy link
Contributor Author

fhebel commented Jun 21, 2024

@Toa741 Thanks again for the fabulous collaboration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants