Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variables with scope #697

Merged
merged 88 commits into from
Jun 21, 2024
Merged

Add variables with scope #697

merged 88 commits into from
Jun 21, 2024

Commits on May 8, 2024

  1. Adapted test cases to GitLab 16.11.1-ee.0 ...

    @fhebel
    fhebel committed May 8, 2024
    Configuration menu
    Copy the full SHA
    936a5b7 View commit details
    Browse the repository at this point in the history

  2. Adapted test cases to GitLab 16.11.1-ee.0 ...

    @fhebel
    fhebel committed May 8, 2024
    Configuration menu
    Copy the full SHA
    285a6aa View commit details
    Browse the repository at this point in the history

  3. Merge branch 'ubisoft:main' into main

    @fhebel
    fhebel authored May 8, 2024
    Configuration menu
    Copy the full SHA
    2cfc72e View commit details
    Browse the repository at this point in the history

  4. First incomplete version of scoped variables ...

    @fhebel
    fhebel committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e60f6ac View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feature/variables-with-scope

    @fhebel
    fhebel committed May 8, 2024
    Configuration menu
    Copy the full SHA
    075abea View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Merge branch 'ubisoft:main' into main

    @fhebel
    fhebel authored May 13, 2024
    Configuration menu
    Copy the full SHA
    bea3178 View commit details
    Browse the repository at this point in the history

  2. Updated Environment PUT api: 

    - Renaming an environment by using the API was deprecated in GitLab 15.9.
- Renaming an environment with the API removed in GitLab 16.0.
    @fhebel
    fhebel committed May 13, 2024
    Configuration menu
    Copy the full SHA
    c0babe4 View commit details
    Browse the repository at this point in the history

  3. Removed obsolete handling for outdated GitLab-version (15.6) ...

    @fhebel
    fhebel committed May 13, 2024
    Configuration menu
    Copy the full SHA
    f824d8d View commit details
    Browse the repository at this point in the history

  4. Updated test user latest activities to current functionality ...

    @fhebel
    fhebel committed May 13, 2024
    Configuration menu
    Copy the full SHA
    675f5c1 View commit details
    Browse the repository at this point in the history

  5. Fixed null comparison ...

    @fhebel
    fhebel committed May 13, 2024
    Configuration menu
    Copy the full SHA
    dca5ce8 View commit details
    Browse the repository at this point in the history

  6. Removed release link external property, deprecated in GitLab 15.9, re… 

    …moved in GitLab 16.0 ...
    @fhebel
    fhebel committed May 13, 2024
    Configuration menu
    Copy the full SHA
    0c1a8b6 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge branch 'main' into feature/gitlab-16.11.1-ee.0

    @fhebel
    fhebel committed May 14, 2024
    Configuration menu
    Copy the full SHA
    0295de8 View commit details
    Browse the repository at this point in the history

  2. Fixed api definitions ...

    @fhebel
    fhebel committed May 14, 2024
    Configuration menu
    Copy the full SHA
    7105395 View commit details
    Browse the repository at this point in the history

  3. Fixed another occurence of Edit with old signature ...

    @fhebel
    fhebel committed May 14, 2024
    Configuration menu
    Copy the full SHA
    db14ff4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'ubisoft:main' into main

    @fhebel
    fhebel authored May 14, 2024
    Configuration menu
    Copy the full SHA
    129077d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feature/variables-with-scope

    @fhebel
    fhebel committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8820815 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Added scoped variable functionality ...

    @fhebel
    fhebel committed May 15, 2024
    Configuration menu
    Copy the full SHA
    79a5ec0 View commit details
    Browse the repository at this point in the history

  2. Set GitLab-versions to test against: 

              'gitlab/gitlab-ee:16.6.2-ee.0'
          'gitlab/gitlab-ee:16.11.1-ee.0'
    @fhebel
    fhebel committed May 15, 2024
    Configuration menu
    Copy the full SHA
    00ea729 View commit details
    Browse the repository at this point in the history

  3. Removed complicated compiler directives ...

    @fhebel
    fhebel committed May 15, 2024
    Configuration menu
    Copy the full SHA
    29db70b View commit details
    Browse the repository at this point in the history

  4. Fixed missing update method signature ...

    @fhebel
    fhebel committed May 15, 2024
    Configuration menu
    Copy the full SHA
    23bebb8 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Test against 'gitlab/gitlab-ee:16.6.2-ee.0' & 'gitlab/gitlab-ee:16.11… 

    ….1-ee.0',
    @fhebel
    fhebel committed May 17, 2024
    Configuration menu
    Copy the full SHA
    63d8672 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ubisoft:main' into feature/gitlab-16.11.1-ee.0

    @fhebel
    fhebel authored May 17, 2024
    Configuration menu
    Copy the full SHA
    56c6c60 View commit details
    Browse the repository at this point in the history

  3. Version bump to gitlab/gitlab-ee:16.11.2-ee.0 ...

    @fhebel
    fhebel committed May 17, 2024
    Configuration menu
    Copy the full SHA
    222dc3e View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/feature/gitlab-16.11.1-ee.0' int… 

    …o feature/gitlab-16.11.1-ee.0
    @fhebel
    fhebel committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c38891f View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Revert "Fixed null comparison ..." 

    This reverts commit dca5ce8.
    @fhebel
    fhebel committed May 27, 2024
    Configuration menu
    Copy the full SHA
    0cf0975 View commit details
    Browse the repository at this point in the history

  2. Revert "Removed obsolete handling for outdated GitLab-version (15.6) … 

    …..."

This reverts commit f824d8d.
    @fhebel
    fhebel committed May 27, 2024
    Configuration menu
    Copy the full SHA
    8b125f3 View commit details
    Browse the repository at this point in the history

  3. Fixed Test_merge_request_api by adding undocumented enum member to De… 

    …tailedMergeStatus ...
    @fhebel
    fhebel committed May 27, 2024
    Configuration menu
    Copy the full SHA
    87bbdf7 View commit details
    Browse the repository at this point in the history

  4. Used louis-z's proposed solution for continued support for version 15… 

    … ...
    @fhebel
    fhebel committed May 27, 2024
    Configuration menu
    Copy the full SHA
    fcdaa4f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'ubisoft:main' into feature/gitlab-16.11.1-ee.0

    @fhebel
    fhebel authored May 27, 2024
    Configuration menu
    Copy the full SHA
    efe72e1 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Still test against version 15.11.x and against latest version 16.11.3… 

    … ...
    @fhebel
    fhebel committed May 29, 2024
    Configuration menu
    Copy the full SHA
    70b831d View commit details
    Browse the repository at this point in the history

  2. Version bump from 16.11.2-ee.0 to 16.11.3-ee.0 ...

    @fhebel
    fhebel committed May 29, 2024
    Configuration menu
    Copy the full SHA
    8e0c37f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'ubisoft:main' into feature/gitlab-16.11.1-ee.0

    @fhebel
    fhebel authored May 29, 2024
    Configuration menu
    Copy the full SHA
    52d9055 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/feature/gitlab-16.11.1-ee.0' int… 

    …o feature/gitlab-16.11.1-ee.0
    @fhebel
    fhebel committed May 29, 2024
    Configuration menu
    Copy the full SHA
    673cf0a View commit details
    Browse the repository at this point in the history

  5. Update supported 16.x versions

    @fhebel
    fhebel committed May 29, 2024
    Configuration menu
    Copy the full SHA
    0c0053f View commit details
    Browse the repository at this point in the history

  6. Added missing handling for root token ...

    @fhebel
    fhebel committed May 29, 2024
    Configuration menu
    Copy the full SHA
    641574c View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Revert "Removed release link external property, deprecated in GitLab … 

    …15.9, removed in GitLab 16.0 ..."

This reverts commit 0c1a8b6.
    @fhebel
    fhebel committed May 30, 2024
    Configuration menu
    Copy the full SHA
    c34bada View commit details
    Browse the repository at this point in the history

  2. Fixed typo ...

    @fhebel
    fhebel committed May 30, 2024
    Configuration menu
    Copy the full SHA
    e4693d0 View commit details
    Browse the repository at this point in the history

  3. Backward compatibility for version 15 

    as suggested by @Toa741 (thanks a lot!)
    @fhebel
    fhebel committed May 30, 2024
    Configuration menu
    Copy the full SHA
    4b218f2 View commit details
    Browse the repository at this point in the history

  4. Revert "Updated Environment PUT api:" 

    This reverts commit c0babe4.
    @fhebel
    fhebel committed May 30, 2024
    Configuration menu
    Copy the full SHA
    bcb02b9 View commit details
    Browse the repository at this point in the history

  5. Revert "Fixed another occurence of Edit with old signature ..." 

    This reverts commit db14ff4.
    @fhebel
    fhebel committed May 30, 2024
    Configuration menu
    Copy the full SHA
    7fdf1fd View commit details
    Browse the repository at this point in the history

  6. Implemented backwards compatible (15.x) version of EnvironmentClient.… 

    …Edit ...

thanks @Toa741
    @fhebel
    fhebel committed May 30, 2024
    Configuration menu
    Copy the full SHA
    47c75eb View commit details
    Browse the repository at this point in the history

  7. Fixed test case for both 15.x and 16.x ...

    @fhebel
    fhebel committed May 30, 2024
    Configuration menu
    Copy the full SHA
    337d70f View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Replaced one line conditions by indented ones ...

    @fhebel
    fhebel committed May 31, 2024
    Configuration menu
    Copy the full SHA
    c379a97 View commit details
    Browse the repository at this point in the history

  2. Removed test code ...

    @fhebel
    fhebel committed May 31, 2024
    Configuration menu
    Copy the full SHA
    e3446ef View commit details
    Browse the repository at this point in the history

  3. Added IsGitLabMajorVersion(int major) to GitLabTestContext as suggest… 

    …ed by @Toa741
    @fhebel
    fhebel committed May 31, 2024
    Configuration menu
    Copy the full SHA
    ff7b257 View commit details
    Browse the repository at this point in the history

  4. Added missing annotations for old environment edit signatures ...

    @fhebel
    fhebel committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f24ade5 View commit details
    Browse the repository at this point in the history

  5. Moved supported ranges to local variables as suggested by @Toa741 ...

    @fhebel
    fhebel committed May 31, 2024
    Configuration menu
    Copy the full SHA
    b93a572 View commit details
    Browse the repository at this point in the history

  6. Moved gitLabVersion to correct place ...

    @fhebel
    fhebel committed May 31, 2024
    Configuration menu
    Copy the full SHA
    1e67377 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Corrected LF ... 

    Co-authored-by: Thomas Cortes <[email protected]>
    @fhebel @Toa741
    fhebel and Toa741 authored Jun 1, 2024
    Configuration menu
    Copy the full SHA
    1c1164d View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Merge branch 'ubisoft:main' into feature/gitlab-16.11.1-ee.0

    @fhebel
    fhebel authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    1d3a7f3 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Resolve GitLab version in GitLabDockerContainer (ubisoft#695) 

    * Resolve GitLab version in GitLabDockerContainer

* Support multiple login inputs on login & token

* Comments

(cherry picked from commit 211acf3)
    @Toa741 @fhebel
    Toa741 authored and fhebel committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    e79bc9a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/gitlab-16.11.1-ee.0

    @fhebel
    fhebel authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    828a5ce View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Merge remote-tracking branch 'origin/main' 

    # Conflicts:
#	NGitLab/IEnvironmentClient.cs
    @fhebel
    fhebel committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    d3cc140 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/variables-with-scope 

    # Conflicts:
#	.github/workflows/ci.yml
#	NGitLab.Tests/Docker/GitLabDockerContainer.cs
    @fhebel
    fhebel committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    dcb9bc1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'ubisoft:main' into feature/variables-with-scope

    @fhebel
    fhebel authored Jun 11, 2024
    Configuration menu
    Copy the full SHA
    591b25e View commit details
    Browse the repository at this point in the history

  4. Reset to lowest supported version as suggested by @Toa741 ...

    @fhebel
    fhebel committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    4606b24 View commit details
    Browse the repository at this point in the history

  5. Changed implementation to support backwards compatibility ...

    @fhebel
    fhebel committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    e83d0a1 View commit details
    Browse the repository at this point in the history

  6. Substituted Obsolete by EditorBrowsableNone ...

    @fhebel
    fhebel committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    527c94b View commit details
    Browse the repository at this point in the history

  7. Substituted some more Obsolete annotations by EditorBrowsableNever ...

    @fhebel
    fhebel committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    ee581b7 View commit details
    Browse the repository at this point in the history

  8. Removed another obsolete annotation ...

    @fhebel
    fhebel committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6322e73 View commit details
    Browse the repository at this point in the history

  9. Added version and license information ...

    @fhebel
    fhebel committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    2e1cf3d View commit details
    Browse the repository at this point in the history

  10. Added new test cases ...

    @fhebel
    fhebel committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    61ec877 View commit details
    Browse the repository at this point in the history

  11. Clarified that create and update of group variables need a license ...

    @fhebel
    fhebel committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    2fc1d33 View commit details
    Browse the repository at this point in the history

  12. Some formatting in order to comply with NGitLab formatting policies ...

    @fhebel
    fhebel committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    fa00ae1 View commit details
    Browse the repository at this point in the history

  13. Added extension class for scoped variables ...

    @fhebel
    fhebel committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    834c3e8 View commit details
    Browse the repository at this point in the history

  14. Added test case for matching scoped variables ...

    @fhebel
    fhebel committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    7543c17 View commit details
    Browse the repository at this point in the history

  15. Some hygiene ..

    @fhebel
    fhebel committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    22029a0 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Remove obsolete return value 

    Co-authored-by: Thomas Cortes <[email protected]>
    @fhebel @Toa741
    fhebel and Toa741 authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    e8646db View commit details
    Browse the repository at this point in the history

  2. Reformatted IDE information ... 

    Co-authored-by: Thomas Cortes <[email protected]>
    @fhebel @Toa741
    fhebel and Toa741 authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    d91506b View commit details
    Browse the repository at this point in the history

  3. Renamed as suggested by @Toa741 ...

    @fhebel
    fhebel committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    bf58a1c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Added additional test as showcase ...

    @fhebel
    fhebel committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    c168edc View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Removed filter feature for specific environment, because it was not a… 

    …pproved by the maintainers ...
    @fhebel
    fhebel committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    1c9c37b View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Removed obsolete environment scope and extracted filter to method ...

    @fhebel
    fhebel committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    f97422e View commit details
    Browse the repository at this point in the history

  2. Extended get in order to be able to specify environment scope ...

    @fhebel
    fhebel committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    ec9586f View commit details
    Browse the repository at this point in the history

  3. Extended and improved variable test cases ...

    @fhebel
    fhebel committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    4425224 View commit details
    Browse the repository at this point in the history

  4. Keeping VariableCreate and VariableUpdate as suggested by @louis-z and … 

    …@Toa741 ...
    @fhebel
    fhebel committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    b9d6ac3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'ubisoft:main' into feature/variables-with-scope

    @fhebel
    fhebel authored Jun 18, 2024
    Configuration menu
    Copy the full SHA
    aa31497 View commit details
    Browse the repository at this point in the history

  6. Some hygiene ...

    @fhebel
    fhebel committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    40aecba View commit details
    Browse the repository at this point in the history

  7. It seems the key of an existing variable can't be changed ...

    @fhebel
    fhebel committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    af42069 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Applied @Toa741's suggestion 

    Separate two signatures in order to prevent breaking change ...

Co-authored-by: Thomas Cortes <[email protected]>
    @fhebel @Toa741
    fhebel and Toa741 authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    824f780 View commit details
    Browse the repository at this point in the history

  2. Applied @Toa741's suggestion 

    environmentScope can't be null ...

Co-authored-by: Thomas Cortes <[email protected]>
    @fhebel @Toa741
    fhebel and Toa741 authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    116eece View commit details
    Browse the repository at this point in the history

  3. Applied @Toa741's suggestion regarding old property Scope

    @fhebel
    fhebel committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    143c88e View commit details
    Browse the repository at this point in the history

  4. Fixed implementation after change of interface ...

    @fhebel
    fhebel committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    e83ced4 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/feature/variables-with-scope' in… 

    …to feature/variables-with-scope
    @fhebel
    fhebel committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    47df36d View commit details
    Browse the repository at this point in the history

  6. VariableCreate is once again used ...

    @fhebel
    fhebel committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    3f18000 View commit details
    Browse the repository at this point in the history

  7. Converted properties back to fields as suggested by @Toa741 ...

    @fhebel
    fhebel committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    b153ebe View commit details
    Browse the repository at this point in the history

  8. Fixed some more implementations of the interface ...

    @fhebel
    fhebel committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    bbdc15a View commit details
    Browse the repository at this point in the history

  9. Fixed another occurence of property instead of field ...

    @fhebel
    fhebel committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    5d0c0a7 View commit details
    Browse the repository at this point in the history