Unity(JUMBO) build support #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sharpmake.Platforms/Sharpmake.CommonPlatforms/BasePlatform.Vcxproj.Template.cs
|
Have you ever checked the Blob feature in sharpmake? It is similar to jumbo builds but is not specific to msbuild. |
jspelletier
reviewed
Nov 1, 2023
| @@ -1605,6 +1605,9 @@ public string FastBuildUnityPath | |||
| /// </remarks> | |||
| public bool DoNotGenerateFastBuild = false; | |||
|
|
|||
| // Unity builds support | |||
| public int MaxFilesPerUnityFile = 0; | |||
There was a problem hiding this comment.
You could maybe reuse the BlobCount
Suggested change
| public int MaxFilesPerUnityFile = 0; | |
| public int MaxFilesPerJumboFile = 0; |
jspelletier
reviewed
Nov 1, 2023
Sharpmake/Project.Configuration.cs
Outdated
| @@ -2476,11 +2479,13 @@ public bool DefaultAddFastBuildProjectToSolution() | |||
| private Dictionary<ValueTuple<Type, ITarget>, DependencySetting> _dependenciesSetting = new Dictionary<ValueTuple<Type, ITarget>, DependencySetting>(); | |||
|
|
|||
| // These dependencies will not be propagated to other projects that depend on us | |||
| internal IDictionary<Type, ITarget> UnResolvedPrivateDependencies { get; } = new Dictionary<Type, ITarget>(); | |||
| //internal IDictionary<Type, ITarget> UnResolvedPrivateDependencies { get; } = new Dictionary<Type, ITarget>(); // hbkim | |||
There was a problem hiding this comment.
What are these changes ?
jspelletier
reviewed
Nov 1, 2023
Sharpmake/Target.cs
Outdated
| @@ -7,6 +7,8 @@ | |||
| using System.Diagnostics; | |||
| using System.Linq; | |||
| using System.Reflection; | |||
| using static Sharpmake.EngineTarget; | |||
There was a problem hiding this comment.
this do not belong in sharpmake codebase.
Define your own Target and fragments in your sharpmake scripts.
jspelletier
reviewed
Nov 1, 2023
| @@ -35,5 +35,13 @@ | |||
| <DisableFastUpToDateCheck>True</DisableFastUpToDateCheck> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'"> | |||
jspelletier
reviewed
Nov 1, 2023
| @@ -1,164 +1,157 @@ | |||
| { | |||
| "profiles": { | |||
There was a problem hiding this comment.
please revert this file.
|
Personal codes was push as my mistake. I've reverted that code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only Unity (JUMBO) build was added.
reference: #234