-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unity(JUMBO) build support #307
Conversation
# Conflicts: # Sharpmake.Platforms/Sharpmake.CommonPlatforms/BasePlatform.Vcxproj.Template.cs
Could modify one of the existing sample to add jumbo build support in one of the configuration at least? |
Co-authored-by: Jean-Sébastien Pelletier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unity -> Jumbo
- Add JumboBuild Sample
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add JumboBuild Sample based on HelloWorld Sample
- Add JumboBuild options
Please let me know if there is anything that needs to be corrected.
Hi @Say-Y. Since you are adding a new sample, could you add it to |
Hi @jspelletier , I added a few header and cpp files. (test1.h, test1.cpp, test2.h, test2.cpp) Hi @sylvainfortin , 'JumboBuild' was added by referring to the 'HelloWorld' part of the 'SamplesDef.json' file. also removed JumboBuild's 'reference' folder. |
UpdateSamplesOutput.bat is used to generate the reference files |
Should I also edit that file?
|
Co-authored-by: Jean-Sébastien Pelletier <[email protected]>
Co-authored-by: Jean-Sébastien Pelletier <[email protected]>
I have applied your request. |
I ran the CI. |
I have confirmed that UpdateSamplesOutput.bat fails without the following settings
After the change, I confirmed that regression_test.py passed. |
I'm familiar with Jumbo build, so I think it would be nice to have this feature integrated.
#305
Apply modifications