Merge pull request #31 from ubuntu-robotics/fix/browser_view_500_error

fix(API): browser post request generated error 500.
ubuntu-robotics · Apr 3, 2024 · 3f45c6b · 3f45c6b
2 parents 13d3627 + 0d9c016
commit 3f45c6b
Showing 1 changed file with 6 additions and 13 deletions.
diff --git a/cos_registration_server/api/views.py b/cos_registration_server/api/views.py
@@ -11,7 +11,6 @@
 from devices.models import Device
 from django.http import HttpResponse
 from rest_framework.exceptions import NotFound
-from rest_framework.parsers import JSONParser
 from rest_framework.request import Request
 from rest_framework.response import Response
 from rest_framework.views import APIView
@@ -50,8 +49,7 @@ def post(self, request: Request) -> Response:
         request: Http GET request.
         return: Http JSON response.
         """
-        data = JSONParser().parse(request)
-        serialized = DeviceSerializer(data=data)
+        serialized = DeviceSerializer(data=request.data)
         if serialized.is_valid():
             serialized.save()
             return Response(serialized.data, status=201)
@@ -87,8 +85,7 @@ def patch(self, request: Request, uid: str) -> Response:
         return: Http JSON response.
         """
         device = self._get_device(uid)
-        data = JSONParser().parse(request)
-        serialized = DeviceSerializer(device, data=data, partial=True)
+        serialized = DeviceSerializer(device, data=request.data, partial=True)
         if serialized.is_valid():
             serialized.save()
             return Response(serialized.data)
@@ -125,8 +122,7 @@ def post(self, request: Request) -> Response:
         request: Http POST request.
         return: Http JSON response.
         """
-        data = JSONParser().parse(request)
-        serialized = GrafanaDashboardSerializer(data=data)
+        serialized = GrafanaDashboardSerializer(data=request.data)
         if serialized.is_valid():
             serialized.save()
             return Response(serialized.data, status=201)
@@ -167,9 +163,8 @@ def patch(self, request: Request, uid: str) -> Response:
         return: Http JSON response.
         """
         dashboard = self._get_dashboard(uid)
-        data = JSONParser().parse(request)
         serialized = GrafanaDashboardSerializer(
-            dashboard, data=data, partial=True
+            dashboard, data=request.data, partial=True
         )
         if serialized.is_valid():
             serialized.save()
@@ -206,8 +201,7 @@ def post(self, request: Request) -> Response:
         request: Http POST request.
         return: Http JSON response.
         """
-        data = JSONParser().parse(request)
-        serialized = FoxgloveDashboardSerializer(data=data)
+        serialized = FoxgloveDashboardSerializer(data=request.data)
         if serialized.is_valid():
             serialized.save()
             return Response(serialized.data, status=201)
@@ -248,9 +242,8 @@ def patch(self, request: Request, uid: str) -> Response:
         return: Http JSON response.
         """
         dashboard = self._get_dashboard(uid)
-        data = JSONParser().parse(request)
         serialized = FoxgloveDashboardSerializer(
-            dashboard, data=data, partial=True
+            dashboard, data=request.data, partial=True
         )
         if serialized.is_valid():
             serialized.save()