-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve peripheral fragments to include more peripheral devices and support instantiating multiple instances of same device #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryz123
reviewed
Jun 14, 2023
}) | ||
|
||
class WithNoDebug extends Config((site, here, up) => { | ||
case DebugModuleKey => None | ||
}) | ||
|
||
class WithDMIDTM extends Config((site, here, up) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this one already provided by rocket-chip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I'm not using this one. I can remove it.
jerryz123
approved these changes
Jun 14, 2023
16 tasks
jerryz123
added a commit
that referenced
this pull request
Jun 19, 2023
…ral"" This reverts commit cb24cf8.
16 tasks
jerryz123
added a commit
that referenced
this pull request
Jul 10, 2023
Improve peripheral config binders (Reapply #1511)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve peripheral fragments to include more peripheral devices and support instantiating multiple instances of same device
This is a new PR regarding the discussion in #1397:
WithUARTOverride
per requested. User can generate ChipConfig from scratch if the default UART address need to be changed.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated thexconda requirements file?Please Backport
?