Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WithUARTInitBaud/fix firesim uart configs #1517

Closed
wants to merge 2 commits into from
Closed

Add WithUARTInitBaud/fix firesim uart configs #1517

wants to merge 2 commits into from

Conversation

jerryz123
Copy link
Contributor

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@T-K-233
Copy link
Member

T-K-233 commented Jun 15, 2023

Duplication of #1511 ?

@abejgonzalez
Copy link
Contributor

Duplication of #1511 ?

This fixes an issue with #1511 (FireSim designs would have 2 UARTs with incorrect baudrates).

@abejgonzalez
Copy link
Contributor

Looks like CI never passed on #1511: https://github.com/ucb-bar/chipyard/actions/runs/5262309568/jobs/9511811129#step:6:6702 can someone add a fix for it?

@jerryz123
Copy link
Contributor Author

Looks like CI never passed on #1511: https://github.com/ucb-bar/chipyard/actions/runs/5262309568/jobs/9511811129#step:6:6702 can someone add a fix for it?

looking at it

@jerryz123
Copy link
Contributor Author

Fixed in this PR

abejgonzalez
abejgonzalez approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved. Waiting on a bitstream build to check the baudrate changes. Thanks Jerry

@jerryz123
Copy link
Contributor Author

I'll fix this together with reverting the reversion in another PR.

@jerryz123 jerryz123 closed this Jun 19, 2023
@jerryz123 jerryz123 deleted the fixuart branch August 18, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abejgonzalez abejgonzalez abejgonzalez approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerryz123 @T-K-233 @abejgonzalez