Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VLSI Fixes #1537

Merged
merged 2 commits into from
Jul 1, 2023
Merged

VLSI Fixes #1537

merged 2 commits into from
Jul 1, 2023

Conversation

nayiri-k
Copy link
Contributor

@nayiri-k nayiri-k commented Jun 30, 2023

The clock name for TinyRocketConfig has changed from clock_clock to clock_uncore_clock.
Also the Make variable PREPROC_DEFINES was renamed to SIM_PREPROC_DEFINES, so Hammer was breaking because the sim.defines YAML key was being set to nothing.

Pulling these changes from #1514 so it's easier to merge for the release.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@nayiri-k nayiri-k requested a review from sagark June 30, 2023 22:09
@jerryz123 jerryz123 merged commit ea26b02 into main Jul 1, 2023
50 checks passed
@jerryz123 jerryz123 deleted the vlsi-fixes branch July 1, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants