Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Re-add -DwriteVcd=1 feature #110

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Re-add -DwriteVcd=1 feature #110

merged 2 commits into from
Jan 15, 2020

Conversation

ducky64
Copy link
Member

@ducky64 ducky64 commented Jan 15, 2020

Was somehow removed in the stage/phase refactor in cbfe5b6 - not sure if intentional. But this adds it back.

Tested with both treadle and Verilator.

@ducky64 ducky64 requested a review from chick January 15, 2020 17:32
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@ducky64 ducky64 merged commit 2f1cbae into master Jan 15, 2020
@ducky64 ducky64 deleted the scalatest-vcd-fix branch January 15, 2020 18:30
@ucbjrl ucbjrl modified the milestones: 0.1.x, 0.1.3 Feb 5, 2020
ucbjrl pushed a commit that referenced this pull request Feb 19, 2020
(cherry picked from commit 2f1cbae)
ucbjrl added a commit that referenced this pull request Feb 19, 2020
* Implement ChiselUtestTester for utest (#76)

(cherry picked from commit da4f226)

* Use latest utest; fix issue utest#211 (#77)

* Use latest utest; fix issue utest#211
* Fix compatibility problem for 2.11 and 2.12

(cherry picked from commit 652a248)

* Add valid io driver (#63)

* Adds an ValidDriver interface similar to Decoupled

* Cleanup imports in ValidQueueTest

* Adds an ValidDriver interface similar to Decoupled
Adds tests for this construct

* Round 2 of ValidDriver support
- change name to validSourceKey
- remove enqueue, only supports enqueueNow
- change how enqueueNow works internally
- Simplify testing of Valid
  - make DUT have delay and typeGen
  - eliminate ValidQueue, just use Pipe instead
  - add example that shows how to enqueue multiple bundles at the same cycle

* Valid interface updates
- Add comment on valid's expectPeek saying it does not advance time
- got rid of errant comment mentioning stall
- used dequeueSeq for pass through elements test
- renamed test with expectInvalid and added loops
- added parens to getSourceClock calls

* - removed wrongly changed entry in .gitignore
- removed duplicated code in ValidQueueTest

(cherry picked from commit 72cb844)

* Fix toolchain so treadle supports boringutils (#79)

* Fix toolchain so treadle supports boringutils
- Add the low firrtl compiler to TreadleExecutive
  - Send hint to treadle so it knows compiled form
- Fix backward compatibility with Driver
  - Check compiler type to help figure out the backend
  - Backward compatibility only supported for treadle and verilator
- Add boringutils test
- Backward compatibilty requires compile workaround
  - Can we just eliminate Driver compatibility mode here???
- Fixed CopyVpiFiles
  - looks like this might fail if early file was there but a late one wasn't
  - this code came from chisel-testers
- Fix top level test names
  - behavior of "Testers2 with Vcs"
  - behavior of "Testers2 with Verilator"
- Shortened VCS to just see if a simple circuit will build and simulate.
  - in long run we still need mechanism to run an arbitrary test with arbitrary backend

* - Made associations between compiler and backend in compat mode explicit
- In BoreTest
  - removed unused code.
- In MixedVec
  - Renamed to VecPokeExpectTest
  - tested all addresses
  - removed bundle

(cherry picked from commit dd6d083)

* Fix external links in README (#84)

(cherry picked from commit b6ea7e9)

* Merge pull request #85 from ucb-bar/peekBundle

Support Bundle literal peek

(cherry picked from commit ea5e81f)

* support enqueue/dequeue of IrrevocableIO (#90)

* support enqueue/dequeue of IrrevocableIO

Signed-off-by: shuyun <[email protected]>

* fix per commit

Signed-off-by: shuyun <[email protected]>
(cherry picked from commit 6767faa)

* Fix missing Scaladoc parenthesis (#92)

Signed-off-by: Schuyler Eldridge <[email protected]>
(cherry picked from commit 7e4ef7f)

* Fix README links (#109)

(cherry picked from commit 2b6cae0)

* Re-add -DwriteVcd=1 feature (#110)

(cherry picked from commit 2f1cbae)

* gitignore: add Visual Studio Code folders (#100)

(cherry picked from commit d9d2a7a)

* Bump minor version

Co-authored-by: Sequencer <[email protected]>
Co-authored-by: Chick Markley <[email protected]>
Co-authored-by: edwardcwang <[email protected]>
Co-authored-by: Richard Lin <[email protected]>
Co-authored-by: ShuyunJia <[email protected]>
Co-authored-by: Schuyler Eldridge <[email protected]>
Co-authored-by: Øyvind Harboe <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants