implement ChiselUtestTester for utest. #76

sequencer · 2019-10-18T17:33:29Z

No description provided.

src/main/scala/chisel3/tester/ChiselUtestTester.scala

edwardcwang · 2019-10-19T22:04:36Z

build.sbt

@@ -41,7 +41,8 @@ resolvers ++= Seq(
 )

 libraryDependencies ++= Seq(
-  "org.scalatest" %% "scalatest" % "3.0.5"
+  "org.scalatest" %% "scalatest" % "3.0.5",
+  "com.lihaoyi" %% "utest" % "0.7.1"


@chick / @ucbjrl This should be OK?

sequencer · 2019-10-20T06:05:20Z

build.sbt

 )
+
+testFrameworks += new TestFramework("utest.runner.Framework")


Additional line to let sbt test invoke utest.

edwardcwang

LGTM, will merge if there are no further objections.

ducky64

So I don't see the same degree of integration with utest compared with the Scalatest environment interface? The main reason the ScalatestTester exists is to provide better integration with ScalaTest to a degree that isn't possible if a failed tester2 expect was to just throw a generic exception - the main example is that a failed expect actually propagates to a Scalatest failure instead of just dumping a stack trace. Is there an analog to utest? If not, would it make more sense to just use RawTester (perhaps with a cleaner API) instead? Note - I'm not too familiar with utest, I only did a cursory glance over the documentation. There may be other benefits to having a utest specific testers2 environment - though that would need to be balanced with the additional code that needs to be maintained as well as requiring additional dependencies.

src/main/scala/chisel3/tester/ChiselUtestTester.scala

sequencer · 2019-10-21T14:35:29Z

Yes, RawTester do work, the original intention of this PR is trying to fix the test function colliding of RawTester.test and utest.test, extending ChiselUtestTester will provide a better interface for utest users, avoiding import renaming.

1. ignore topFileName, use utestFormatter directly highlight the error line. 2. use utest.testPath provide test name like scalatest does in scalaTestContext.

ucbjrl · 2019-10-22T21:16:08Z

Unfortunately, there doesn't appear to be a Scala 2.11 version of utest 07.1, which is causing current CI builds to fail:

[info] Setting Scala version to 2.11.12 on 1 projects.
[info] Reapplying settings...
[info] Set current project to chisel-testers2 (in build file:/vm/home/jenkins/sharedspace/chisel3-full/testers2/)
[info] Wrote /vm/home/jenkins/sharedspace/chisel3-full/testers2/target/scala-2.11/chisel-testers2_2.11-0.1-SNAPSHOT.pom
[warn] 
[warn] 	Note: Unresolved dependencies path:
[error] sbt.librarymanagement.ResolveException: Error downloading com.lihaoyi:utest_2.11:0.7.1
[error]   Not found
[error]   Not found
[error]   not found: /vm/home/jenkins/sharedspace/chisel3-full/ivy2/local/com.lihaoyi/utest_2.11/0.7.1/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/com/lihaoyi/utest_2.11/0.7.1/utest_2.11-0.7.1.pom
[error]   not found: https://oss.sonatype.org/content/repositories/snapshots/com/lihaoyi/utest_2.11/0.7.1/utest_2.11-0.7.1.pom
[error]   not found: https://oss.sonatype.org/content/repositories/releases/com/lihaoyi/utest_2.11/0.7.1/utest_2.11-0.7.1.pom

I'll file an issue on https://github.com/lihaoyi/utest

sequencer · 2019-10-22T21:24:27Z

Oh sorry. I didn’t remember we have to support 2.11, I’ll try to pr that later.

sequencer · 2019-10-22T21:32:42Z

I just found that they

Dropped support for Scala 2.10.x, 2.11.x

in 0.6.9
Emmm, maybe we can lock utest to 0.6.8 until we dropped 2.11.x?
It seems that since 0.6.8, there is no functional change.

(cherry picked from commit da4f226)

* Implement ChiselUtestTester for utest (#76) (cherry picked from commit da4f226) * Use latest utest; fix issue utest#211 (#77) * Use latest utest; fix issue utest#211 * Fix compatibility problem for 2.11 and 2.12 (cherry picked from commit 652a248) * Add valid io driver (#63) * Adds an ValidDriver interface similar to Decoupled * Cleanup imports in ValidQueueTest * Adds an ValidDriver interface similar to Decoupled Adds tests for this construct * Round 2 of ValidDriver support - change name to validSourceKey - remove enqueue, only supports enqueueNow - change how enqueueNow works internally - Simplify testing of Valid - make DUT have delay and typeGen - eliminate ValidQueue, just use Pipe instead - add example that shows how to enqueue multiple bundles at the same cycle * Valid interface updates - Add comment on valid's expectPeek saying it does not advance time - got rid of errant comment mentioning stall - used dequeueSeq for pass through elements test - renamed test with expectInvalid and added loops - added parens to getSourceClock calls * - removed wrongly changed entry in .gitignore - removed duplicated code in ValidQueueTest (cherry picked from commit 72cb844) * Fix toolchain so treadle supports boringutils (#79) * Fix toolchain so treadle supports boringutils - Add the low firrtl compiler to TreadleExecutive - Send hint to treadle so it knows compiled form - Fix backward compatibility with Driver - Check compiler type to help figure out the backend - Backward compatibility only supported for treadle and verilator - Add boringutils test - Backward compatibilty requires compile workaround - Can we just eliminate Driver compatibility mode here??? - Fixed CopyVpiFiles - looks like this might fail if early file was there but a late one wasn't - this code came from chisel-testers - Fix top level test names - behavior of "Testers2 with Vcs" - behavior of "Testers2 with Verilator" - Shortened VCS to just see if a simple circuit will build and simulate. - in long run we still need mechanism to run an arbitrary test with arbitrary backend * - Made associations between compiler and backend in compat mode explicit - In BoreTest - removed unused code. - In MixedVec - Renamed to VecPokeExpectTest - tested all addresses - removed bundle (cherry picked from commit dd6d083) * Fix external links in README (#84) (cherry picked from commit b6ea7e9) * Merge pull request #85 from ucb-bar/peekBundle Support Bundle literal peek (cherry picked from commit ea5e81f) * support enqueue/dequeue of IrrevocableIO (#90) * support enqueue/dequeue of IrrevocableIO Signed-off-by: shuyun <[email protected]> * fix per commit Signed-off-by: shuyun <[email protected]> (cherry picked from commit 6767faa) * Fix missing Scaladoc parenthesis (#92) Signed-off-by: Schuyler Eldridge <[email protected]> (cherry picked from commit 7e4ef7f) * Fix README links (#109) (cherry picked from commit 2b6cae0) * Re-add -DwriteVcd=1 feature (#110) (cherry picked from commit 2f1cbae) * gitignore: add Visual Studio Code folders (#100) (cherry picked from commit d9d2a7a) * Bump minor version Co-authored-by: Sequencer <[email protected]> Co-authored-by: Chick Markley <[email protected]> Co-authored-by: edwardcwang <[email protected]> Co-authored-by: Richard Lin <[email protected]> Co-authored-by: ShuyunJia <[email protected]> Co-authored-by: Schuyler Eldridge <[email protected]> Co-authored-by: Øyvind Harboe <[email protected]>

sequencer added 2 commits October 18, 2019 17:30

implement ChiselUtestTester for utest.

bdeb35e

add dependency and doc for Utest

0fb313c

edwardcwang reviewed Oct 19, 2019

View reviewed changes

sequencer added 2 commits October 20, 2019 05:43

update for edward's review.

2fc2ab8

add UtestTesterTest to test utest framework

994b718

sequencer commented Oct 20, 2019

View reviewed changes

edwardcwang approved these changes Oct 20, 2019

View reviewed changes

ducky64 reviewed Oct 21, 2019

View reviewed changes

src/main/scala/chisel3/tester/ChiselUtestTester.scala Outdated Show resolved Hide resolved

src/main/scala/chisel3/tester/ChiselUtestTester.scala Outdated Show resolved Hide resolved

fix indent

41f1499

make test result for ChiselUtestTester more readable:

9608ec3

1. ignore topFileName, use utestFormatter directly highlight the error line. 2. use utest.testPath provide test name like scalatest does in scalaTestContext.

edwardcwang merged commit da4f226 into ucb-bar:master Oct 22, 2019

sequencer deleted the utest_support branch October 22, 2019 17:35

ucbjrl modified the milestones: 0.1.x, 0.1.3 Feb 5, 2020

ucbjrl pushed a commit that referenced this pull request Feb 19, 2020

Implement ChiselUtestTester for utest (#76)

098e859

(cherry picked from commit da4f226)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement ChiselUtestTester for utest. #76

implement ChiselUtestTester for utest. #76

sequencer commented Oct 18, 2019

edwardcwang Oct 19, 2019

sequencer Oct 20, 2019

edwardcwang left a comment

ducky64 left a comment

sequencer commented Oct 21, 2019

ucbjrl commented Oct 22, 2019

sequencer commented Oct 22, 2019

sequencer commented Oct 22, 2019 •

edited

Loading

		)

		testFrameworks += new TestFramework("utest.runner.Framework")

implement ChiselUtestTester for utest. #76

implement ChiselUtestTester for utest. #76

Conversation

sequencer commented Oct 18, 2019

edwardcwang Oct 19, 2019

Choose a reason for hiding this comment

sequencer Oct 20, 2019

Choose a reason for hiding this comment

edwardcwang left a comment

Choose a reason for hiding this comment

ducky64 left a comment

Choose a reason for hiding this comment

sequencer commented Oct 21, 2019

ucbjrl commented Oct 22, 2019

sequencer commented Oct 22, 2019

sequencer commented Oct 22, 2019 • edited Loading

sequencer commented Oct 22, 2019 •

edited

Loading