This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
VCS Q-2020.03 (at least) fails because it can't find nullptr #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ekiwi
reviewed
Dec 6, 2022
| @@ -32,7 +32,7 @@ class vpi_api_t: public sim_api_t<vpiHandle> { | |||
| vpiHandle syscall_handle = vpi_handle(vpiSysTfCall, NULL); | |||
| vpiHandle arg_iter = vpi_iterate(vpiArgument, syscall_handle); | |||
| // Cache Inputs | |||
| if(arg_iter != nullptr) { | |||
| if(arg_iter != NULL) { | |||
There was a problem hiding this comment.
this seems reasonable.
Probably this is somehow compiled by an old compiler which does not support C++11 (https://en.cppreference.com/w/cpp/language/nullptr) by default.
ekiwi
added
the
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
(cherry picked from commit 9c6b387)
mergify
bot
added
the
Backported
mergify bot
added a commit
that referenced
this pull request
Dec 7, 2022
…573) (cherry picked from commit 9c6b387) Co-authored-by: Steve Burns <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VCS (version Q-2020.03) integration with chiseltest fails with a compiler error when compiling vpi.cpp. It seems that
nullptris not defined. Everywhere else,NULLseems to be used for the same thing. I made that change and now all my tests in chisel-pla work withtreadle,verilatorand nowvcs.I don't know your testing strategy for VCS because it is not an open source tool. Let me know if you would like me to run any tests on
mainagainst these changes.