This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Remove quotes around VcsCFlags #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekiwi
approved these changes
Dec 6, 2022
ekiwi
added
the
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
* Remove quotes around VcsCFlags * Revert back to using nullptr * Remove added blank line (cherry picked from commit 24e4ec4)
mergify
bot
added
the
Backported
ekiwi
pushed a commit
that referenced
this pull request
Dec 7, 2022
* Remove quotes around VcsCFlags * Revert back to using nullptr * Remove added blank line (cherry picked from commit 24e4ec4) Co-authored-by: Steve Burns <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the real fix for the issue addressed in PR #572
The reason for the
nullptrnot being found compiler error was that the-std=c++11flag was not being seen by an older compiler (gcc 4.8.5). What was actually being run was the command line:The double quotes around the command line options in the middle meant that they were not being treated separately, and silently then
-std=c+11options was being ignored.The proposed fix corrects this issue, and we can leave the
nullptrusages in thevpi.hfile.Also, the
VcsCFlagsannotation will to work, allowing new C compiler flags to be added as necessary by the user.