Add support of Symfony 3.0 #85
Conversation
francoispluchino
commented
Dec 11, 2015
francoispluchino
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #84 |
| License | MIT |
| Doc PR | ~ |
| @@ -16,7 +16,7 @@ class FileProvider extends AbstractProvider | |||
|
|
|||
| public function __construct($name, array $options, $client, Cache $cache, Logger $logger) { | |||
| $this->name = $name; | |||
| /** @var md5 only contain numeric and A to F, so it is file system safe */ | |||
| /** md5 only contain numeric and A to F, so it is file system safe */ | |||
There was a problem hiding this comment.
The comment should not start with /** which indicates a docblock.
|
There is no job on Travis performing a build with Symfony 3. |
|
It's done. |
|
Travis test Symfony 3.0 with PHP 5.4. What is the config for testing Symfony 3.0 with PHP 5.5 and greater? |
|
The config of Travis is fixed now. |
|
👍 LGTM The Travis CI configuration can be improved but that should better be done in a separate pull request. |
|
Ok, I'm interested by your optimization of the Travis config. |
|
@francoispluchino You can take a look at my changes in #86 (one job is currently failing because of a YAML syntax error that will be fixed by #87). |
|
@xabbuh Thanks! |
| "symfony/http-kernel": "~2.3, <3.0.0@dev", | ||
| "symfony/console": "~2.3, <3.0.0@dev", | ||
| "symfony/monolog-bundle": "~2.3, <3.0.0@dev" | ||
| "symfony/dependency-injection": "~2.3|~3.0", |
There was a problem hiding this comment.
while you are in here, change the ~'s to ^'s
There was a problem hiding this comment.
i would actually say ^3.0, but you could change the other ~'s too
There was a problem hiding this comment.
Ok I do this.
|
The inspection completed: 26 Issues, 0 Patches |
|
It's ok for you now? |
|
@francoispluchino Thanks! |
