Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Travis CI configuration #86

Merged
merged 2 commits into from
Dec 18, 2015
Merged

improve Travis CI configuration #86

merged 2 commits into from
Dec 18, 2015

Conversation

xabbuh
Copy link
Contributor

@xabbuh xabbuh commented Dec 11, 2015

  • fix the Composer cache directory
  • run jobs with different Symfony versions only on PHP 5.6
  • drop jobs for Symfony versions that reached EOL
  • add job for PHP 7
  • run code coverage reports only on PHP 7
  • disable Xdebug when code coverage reports won't be generated
  • finish as soon as possible (when either a mandatory job failed or only
    jobs that are allowed to fail are running)

* fix the Composer cache directory
* run jobs with different Symfony versions only on PHP 5.6
* drop jobs for Symfony versions that reached EOL
* add job for PHP 7
* run code coverage reports only on PHP 7
* disable Xdebug when code coverage reports won't be generated
* finish as soon as possible (when either a mandatory job failed or only
  jobs that are allowed to fail are running)
@xabbuh xabbuh mentioned this pull request Dec 11, 2015
@scrutinizer-notifier
Copy link

The inspection completed: 28 Issues, 1 Patches

@cryptiklemur
Copy link
Contributor

Is it worth removing 2.6? Its EOLed in less than a month

@cryptiklemur
Copy link
Contributor

by the time @kmfk merges this, it'll be EOLed ;)

@k-k
Copy link
Contributor

k-k commented Dec 18, 2015

@xabbuh - Thanks for this! I tried rebuilding your failed tests after merging #87 - but I still get the same error in Travis.

There are also tests failing where we previously checked for PHPUnit_Framework_Errors - but are now properly throwing TypeErrorExceptions in PHP 7. (see here).

Maybe create new tests for the correct exceptions and group them in PHPUnit so they can be ignored on the other tests - or use version_compare() inside the test to expect the correct exception?

@k-k
Copy link
Contributor

k-k commented Dec 18, 2015

Rebuilding this again, the YAML fix did actually work. I'm gonna merge this and fix the other tests in a separate PR.

@k-k k-k merged commit d373a2f into uecode:master Dec 18, 2015
@xabbuh xabbuh deleted the patch-1 branch December 19, 2015 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants