Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCAR/main PR #972 #17

Merged
merged 59 commits into from
Nov 21, 2022
Merged

Conversation

dustinswales
Copy link
Collaborator

This PR adds continuous integration tests to run the ccpp_prebuild script for all available host models, currently NCAR/ccpp-scm and NOAA-EMC/fv3atm.

For each host-model, the scripts do the following:

  • Check out local ccpp-physics code (save github URL and branch information)
  • Check out host-model interface and ccpp_prebuild
  • Switch host-model ccpp-physics to use local ccpp-physics
  • Set up Python environment (v3.8.5)
  • Run ccpp_prebuild.py

This is done for all commits, alerting developers to changes that break the host-model coupling to the ccpp-physics

@jkbk2004
Copy link

@dustinswales this pr is only to do with ccpp git action. can we coordinate to combine with ufs-wm pr 1486 ?

@jkbk2004
Copy link

Or since only yaml file changes for ccpp git workflow/action, @ChunxiZhang-NOAA @dustinswales we are ok tp combine this pr to either #18 or #19. I think this option is easier. can we agree?

@ChunxiZhang-NOAA
Copy link

@jkbk2004 I would like to keep each ccpp-physics PR separate. The best option is to combine with ufs-wm PR#1486.

@dustinswales
Copy link
Collaborator Author

@jkbk2004 @ChunxiZhang-NOAA I have no preference. Whatever is easiest for you from a code management perspective.

@jkbk2004
Copy link

@dustinswales next good chance to merge in this pr is to combine with ufs wm pr 1492. Can you create a fv3atm fork branch containing this pr and create a pr to fv3atm? So that we can coordinate to combine with ufs wm pr 1492. @ChunxiZhang-NOAA that's a way we can go, right?

@ChunxiZhang-NOAA
Copy link

@jkbk2004 Yes, that's the best way, thanks.

@dustinswales
Copy link
Collaborator Author

@jkbk2004
Copy link

@ChunxiZhang-NOAA can you merge in this pr? so that we can move on to merge in down stream prs on fv3atm and weather model side.

@ChunxiZhang-NOAA ChunxiZhang-NOAA merged commit 82062de into ufs-community:ufs/dev Nov 21, 2022
@ChunxiZhang-NOAA
Copy link

@jkbk2004 Sure. Done.

@dustinswales dustinswales deleted the add_ci_tests branch March 15, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants