Modify the Thompson scheme to improve radiative fluxes and cloud cover for HR1 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunxiZhang-NOAA
requested review from
RuiyuSun,
gthompsnWRF and
dustinswales
This was referenced Nov 2, 2022
RuiyuSun
approved these changes
Nov 2, 2022
dustinswales
reviewed
Nov 4, 2022
dustinswales
reviewed
Nov 4, 2022
dustinswales
reviewed
Nov 4, 2022
dustinswales
reviewed
Nov 4, 2022
dustinswales
reviewed
Nov 4, 2022
dustinswales
reviewed
Nov 4, 2022
dustinswales
reviewed
Nov 4, 2022
dustinswales
reviewed
Nov 4, 2022
grantfirl
reviewed
Nov 4, 2022
grantfirl
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Looks OK to me. I only had one question and it would be nice if commented lines were removed like @dustinswales suggested.
…le_mp_thompson.F90
gthompsnWRF
requested changes
Nov 4, 2022
|
Looks fine. |
|
Thank you Ruiyu! The commit process will start soon. |
|
@ChunxiZhang-NOAA Yes, I will hit approve. I just wanted Ruiyu (possibly others) to know why that line 300 could not be changed to D0s+100. I wish everyone would be more careful not to change what they might perceive as a simple constant. More thorough investigation is sometimes needed. |
gthompsnWRF
approved these changes
Nov 7, 2022
|
@gthompsnWRF Thank you so much! Totally understood. It is always good to provide more detailed explanations. |
Merged
grantfirl
pushed a commit
that referenced
this pull request
May 21, 2024
Add optional attribute to Fortran files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created on behalf of @RuiyuSun to resolve Issue#21.
The purpose of this PR is to reduce the biases in the radiative fluxes, cloud cover, and surface temperature by modifying the Thompson microphysics scheme and its related part in the RRTMG(P) pre interstitial code.
The PR includes:
Another modification included in the following testing but not included in this PR is:
The convective cloud condensate is used in the radiative flux calculation.
This modification is included in PR#9.
The testing results based on P8C is here.
Copy of Coupled experiments based on P8C Evaluation_GFS_p8cctl_p8c15_p8c15cnvwinrad (1).pptx
The testing results based on GFSv17 is here.
GFSv17_highresol_cnvwinradiation_202007_202008 [Autosaved].pptx