Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for cloud effective radius for convective clouds (HR1) #35

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

ChunxiZhang-NOAA
Copy link

@ChunxiZhang-NOAA ChunxiZhang-NOAA commented Jan 25, 2023

This is an emergency bug fix for cloud effective radius for convective clouds (Issue#36). For a temporary solution, 50 micro and 10 micro is assigned to convective cloud ice and liquid, respectively. More physics-based values will be assigned in the future improvement in HR2. The test results are here.
GFSv17_highresol_cnvwinradiation_bugfix_in_convective_condensate.pptx

Copy link
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChunxiZhang-NOAA Looks good to me.

Copy link
Collaborator

@RuiyuSun RuiyuSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine to me.

@ChunxiZhang-NOAA
Copy link
Author

@grantfirl Could you review this PR at your convenience? thanks.

@ChunxiZhang-NOAA
Copy link
Author

@grantfirl Thank you!

@BrianCurtis-NOAA
Copy link

All testing completed and passed in UFSWM. Please merge.

@grantfirl grantfirl merged commit c44a717 into ufs-community:ufs/dev Jan 30, 2023
dustinswales pushed a commit that referenced this pull request Nov 2, 2023
Bug fix for cloud effective radius for convective clouds (HR1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants