Update SCM for NCAR PR #956 and UFS #35 #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grantfirl All tests passed. I think good to merge (see below) Baselines are different for a few p8 cases, which is expected since there are changes to the Thompson MP scheme, but not all the p8 cases? I wonder if this change doesn't get triggered/exercised by all cases in the SCM RTs with Thompson MP enabled? (These are itsy-bitsy cases we are running). |
grantfirl
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the SCM up-to-date with the HEAD of NCAR:main.
Changes include: UWM:ufs/dev #35 and NCAR:main #956