Improve radiative fluxes and cloud cover in FV3 for HR1 #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FS_rrtmg_pre.F90 and module_mp_thompson.F90
|
@ChunxiZhang-NOAA we can start working on this pr. Can you resolve the conflicts? |
I will make the changes and let you know when it is ready. |
on-behalf-of @ufs-community <[email protected]>
on-behalf-of @ufs-community <[email protected]>
|
Jenkins-ci logs attached. |
on-behalf-of @ufs-community <[email protected]>
on-behalf-of @ufs-community <[email protected]>
DusanJovic-NOAA
approved these changes
Nov 8, 2022
…ather-model into feature/mp_cloud
|
@ChunxiZhang-NOAA all test are done. we can start merging process. Can you merge in the ccpp dependency first? |
|
@jkbk2004 Sure. ccpp-physics PR#19 was merged into ufs/dev. I will update the pointer and hash. |
|
@jkbk2004 ccpp-physics pointer was reverted in fv3atm. |
|
@ChunxiZhang-NOAA fv3 pr was merged. we can merge in this pr with hash update and reverting gitmodules branch. |
|
@jkbk2004 Done. |
BrianCurtis-NOAA
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Description
This PR is associated with ccpp-physics PR#19 to improve radiative fluxes and cloud cover calculation in GFSv17 by modifying the Thompson microphysics scheme and its connection to the radiation scheme. This implementation is for HR1.
Issue(s) addressed
Testing
The regression tests are conducted on hera.intel and all the tests used the Thompson microphysics scheme failed due to baseline changes. The control_p8, which uses the Thompson scheme, was selected for the ORT test, and the ORT test was successful.
Dependencies