Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login for real e2e tests #207

Closed
dominikfeininger opened this issue Mar 29, 2022 · 13 comments
Closed

Login for real e2e tests #207

dominikfeininger opened this issue Mar 29, 2022 · 13 comments
Assignees
@monavari-lebrecht @vobu
Labels
enhancement New feature or request feature request in Progress
Milestone
results from stee...

Comments

@dominikfeininger
Copy link
Collaborator

No description provided.

@dominikfeininger dominikfeininger self-assigned this Mar 29, 2022
@vobu
Copy link
Contributor

vobu commented Mar 31, 2022

yep, see https://github.com/orgs/js-soft/projects/1/views/4?filterQuery=extension

@dominikfeininger
Copy link
Collaborator Author

added script in this branch: https://github.com/js-soft/wdi5/tree/feature/e2eLogin

maybe is misunderstood the requirements?

@github-actions
Copy link

github-actions bot commented May 7, 2022

hey 👋 - silence for 30 days 🤐 ... anybody? 😀

@github-actions github-actions bot added the stale label May 7, 2022
@vobu
Copy link
Contributor

vobu commented May 9, 2022

in the works

@vobu vobu removed the stale label May 9, 2022
@dominikfeininger
Copy link
Collaborator Author

might be contributed by QMate Team

@dominikfeininger dominikfeininger removed their assignment May 17, 2022
@T1mey
Copy link

T1mey commented May 31, 2022

What's the actual state ? Will this roadmap step provide authentication for testing of users with differnent permissions / roles ?

@vobu
Copy link
Contributor

vobu commented May 31, 2022

still WIP, with generic BTP login coming first.
This also means that the roles/permissions for the UI5 app depend on the roles/permissions the logged in user has.

@T1mey
Copy link

T1mey commented May 31, 2022

still WIP, with generic BTP login coming first. This also means that the roles/permissions for the UI5 app depend on the roles/permissions the logged in user has.

That means that the testuser will authenticate against the BTP and must exist there. As we're using an own IDP with certificate based login this will be a bit tricky, right? Will this scenario be supported?

@APatrina
Copy link

Hello colleagues, @vobu @dominikfeininger @T1mey, the priority of this ticket for our project is high now. It was raise on March, and we are unable to integrate our e2e tests in an automated jenkins job.
Could you please increase the priority and provide information regarding deadlines of resolving this? Thank you very much.

@vobu
Copy link
Contributor

vobu commented Jun 28, 2022

there's been some back and forth on this topic - originally we thought that some SAP colleagues will contribute the authentication part, but that got stalled into the void.
so it's back to square one on this, albeit the original plans have not changed; meaning:
wdi5 will support:

  • standard BTP IdP login (w/ username + password)
  • SAP Universal ID based login (w/ selector on what User Id to use)
  • FLP login

with the standard IdP coming first.

given the current track record, I'll refrain from promising any delivery dates.
but hey, here's an idea: if it's super urgent for you @APatrina, why don't you give it a shot yourself? A good starting point would be to provide the login capability on the wdi5 object itself https://github.com/js-soft/wdi5/blob/main/src/wdi5.ts - for usage in a WebdriverIO before().

@vobu vobu added enhancement New feature or request help wanted Extra attention is needed and removed on hold labels Jun 28, 2022
@vobu vobu added this to wdi5 roadmap Jul 5, 2022
@vobu vobu moved this to In Progress 🚧 in wdi5 roadmap Jul 5, 2022
@vobu vobu self-assigned this Jul 28, 2022
@maiargu maiargu mentioned this issue Jul 29, 2022
Closed
@dnzxy
Copy link

dnzxy commented Oct 20, 2022 •
edited
Loading

Hi, this issue has now been open for almost 7 months, with the last mention of it "being in the works" dating back to end of June. Very recently, during your Devtoberfest session on wdi5, @vobu, you reiterated that authentication features are "in the works". I see that it's part of the in progress roadmap, but is there any update on this?

@vobu
Copy link
Contributor

vobu commented Oct 20, 2022

@monavari-lebrecht is leading the dev effort for this and still on it.
given that he's doing it in his spare time, things take longer than as if it'd be a paid dev effort.
that being said, would you have capacity to help? or a sponsorship opportunity?

@vobu vobu mentioned this issue Nov 11, 2022
Merged
vobu added a commit that referenced this issue Nov 14, 2022
@vobu @Siolto
@dominikfeininger @monavari-lebrecht
feat: authentication capabilities (#369)
9c23bda 
authentication capabilities:

- BTP SAP Cloud IdP
- BTP Standard IdP
- Office 365
- Basic Auth
- custom auth fields

authentication works for single browser scenarios as well as multiremote.

credentials and authentication types are provided at design-time through configuration and don't require code changes.
docs still todo, short version is:
- standard: provide env vars `wdi5_username` and `wdi5_password` w/ respective values
- multiremote: provide env var s`wdi5_$remote-id_username` and `wdi5_$remote-id_password` w/ respective values
- add `wdi5:authentication` config object (see `src/types/wdi5.types.ts` → `*Authenticator`) to the `capabilities` section of the `wdio.conf.(t|j)s` file

addressing #207 

Co-authored-by: scoen <[email protected]>
Co-authored-by: dominik.feininger <[email protected]>
Co-authored-by: Constantin Lebrecht <[email protected]>
@dominikfeininger
Copy link
Collaborator Author

solved with https://github.com/ui5-community/wdi5/releases/tag/v1.0.0-pre.1

Repository owner moved this from In Progress 🚧 to Done 🚀 in wdi5 roadmap Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monavari-lebrecht monavari-lebrecht

@vobu vobu

Labels
enhancement New feature or request feature request in Progress
Projects
wdi5 roadmap
Status: Done 🚀
Milestone
results from steering committee 1
Development

No branches or pull requests
6 participants
@monavari-lebrecht @dominikfeininger @vobu @T1mey @dnzxy @APatrina