-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: authentication capabilities #369
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce authenticator .conf file - introduce authenticator test scripts - add first dummy btp authenticator login script - add dotenv to load .env variables - authenticate when wdi5_authenticate is in capabilities
- move authenticator tests to the ts-app - add BasicAuth support and tests - enhance BTP login
- enhance super Authenticator for multiRemote support - introduce getter methods for username and password - update already existing authenticators for multi remote Co-authored-by: Volker Buzek <[email protected]> Co-authored-by: Constantin Lebrecht <[email protected]>
to hold back on wdio8
… feat/authenticator
monavari-lebrecht
approved these changes
Nov 13, 2022
Siolto
requested changes
Nov 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw error when obligatory parameters for custom auth are missing, needs to be implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
authentication capabilities:
authentication works for single browser scenarios as well as multiremote.
credentials and authentication types are provided at design-time through configuration and don't require code changes.
docs still todo, short version is:
wdi5_username
andwdi5_password
w/ respective valueswdi5_$remote-id_username
andwdi5_$remote-id_password
w/ respective valueswdi5:authentication
config object (seesrc/types/wdi5.types.ts
→*Authenticator
) to thecapabilities
section of thewdio.conf.(t|j)s
fileaddressing #207