-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V10/bugfix/14543 publish descendants #14763
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he root when its part of a branch
Zeegaan
requested changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few small things 👀
Co-authored-by: Nikolaj Geisle <[email protected]>
Co-authored-by: Nikolaj Geisle <[email protected]>
Co-authored-by: Nikolaj Geisle <[email protected]>
Looks good, tests good! |
Zeegaan
added a commit
that referenced
this pull request
Sep 5, 2023
* WIP: Fix publish descendants and related notifications * Removed related entitities from publish notification * Fixed root not being saved when publishingWithDescendants * Updated integrationtests to reflect the update view on when to save the root when its part of a branch * PR formatting fix Co-authored-by: Nikolaj Geisle <[email protected]> * PR Cleanup Co-authored-by: Nikolaj Geisle <[email protected]> * Spicing up the codebase with some PR pattern matching Co-authored-by: Nikolaj Geisle <[email protected]> --------- Co-authored-by: Sven Geusens <[email protected]> Co-authored-by: Nikolaj Geisle <[email protected]>
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
Fix for #14543
Description
Reproduction steps
Add the following classes to your project
Each pair (save or publish) should be hit for every child that has unpublished changes when executing publish with descendants on a parent (or ancestor for that matter).
These pairs should also be called on the parent
And the state should be passed between each item in a pair.