Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V10/bugfix/14543 publish descendants #14763

Merged
merged 7 commits into from
Sep 5, 2023

Updated integrationtests to reflect the update view on when to save t…

32eaa92
Select commit
Loading
Failed to load commit list.
Merged

V10/bugfix/14543 publish descendants #14763

Updated integrationtests to reflect the update view on when to save t…
32eaa92
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v10/dev) failed Sep 4, 2023 in 38s

CodeScene PR Check

❌ Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Negative Code Health Impact (highest to lowest):

  • Complex Method ContentService.cs: SaveAndPublishBranch_ShouldPublish 🔥

Annotations

Check notice on line 1 in src/Umbraco.Core/Services/ContentService.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v10/dev)

ℹ Getting worse: Overall Code Complexity 

The mean cyclomatic complexity increases from 5.39 to 5.40, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check warning on line 1953 in src/Umbraco.Core/Services/ContentService.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v10/dev)

❌ Getting worse: Complex Method 

SaveAndPublishBranch_ShouldPublish increases in cyclomatic complexity from 9 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis