Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken icons for instance with relative path #1468

Merged
merged 2 commits into from
Aug 24, 2022
Merged

fix broken icons for instance with relative path #1468

merged 2 commits into from
Aug 24, 2022

Conversation

akellbl4
Copy link
Collaborator

Resolves #1380

@akellbl4 akellbl4 requested a review from Mavrin August 24, 2022 02:49
@akellbl4 akellbl4 requested a review from umputun as a code owner August 24, 2022 02:49
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #1468 (f729519) into master (dc048ef) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1468      +/-   ##
==========================================
- Coverage   58.14%   58.12%   -0.02%     
==========================================
  Files         131      131              
  Lines        2910     2909       -1     
  Branches      743      743              
==========================================
- Hits         1692     1691       -1     
  Misses       1214     1214              
  Partials        4        4              
Impacted Files Coverage Δ
...d/apps/remark42/app/components/comment/comment.tsx 62.38% <ø> (ø)
...end/apps/remark42/app/components/comment/styles.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 24, 2022

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 72.51 KB (+0.15% 🔺)
public/remark.css 8.15 KB (-0.61% 🔽)
public/last-comments.mjs 35.63 KB (+0.28% 🔺)
public/last-comments.css 3.72 KB (-1.81% 🔽)
public/deleteme.mjs 12.05 KB (0%)
public/counter.mjs 749 B (0%)

@umputun umputun merged commit 499302c into master Aug 24, 2022
@umputun umputun deleted the fix-1380 branch August 24, 2022 16:37
@paskal paskal added this to the v1.10.2 milestone Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links in remark.css when using Remark42 without subdomain.
4 participants