Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken icons for instance with relative path #1468

Merged
merged 2 commits into from
Aug 24, 2022
Merged

fix broken icons for instance with relative path #1468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50a4fd4
fix broken icons
akellbl4 Aug 24, 2022
f729519
Merge branch 'master' into fix-1380
Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...mponents/comment/__link-to-parent/_focused/comment__link-to-parent__focused.svg
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions frontend/apps/remark42/app/components/comment/__link-to-parent/comment__link-to-parent.css
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions ...ps/remark42/app/components/comment/__link-to-parent/comment__link-to-parent.svg
View file
Open in desktop

This file was deleted.

13 changes: 13 additions & 0 deletions frontend/apps/remark42/app/components/comment/comment.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,16 @@
opacity: 0.75;
}
}

.threadStarterAnchor {
display: inline-flex;
height: 1rem;
width: 1rem;
color: var(--color35);
justify-content: center;
align-items: center;

&:hover {
color: var(--color29);
}
}
10 changes: 7 additions & 3 deletions frontend/apps/remark42/app/components/comment/comment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,13 +446,17 @@ export class Comment extends Component<CommentProps, State> {

{!!props.level && props.level > 0 && props.view === 'main' && (
<a
className="comment__link-to-parent"
className={styles.threadStarterAnchor}
href={`${o.locator.url}#${COMMENT_NODE_CLASSNAME_PREFIX}${o.pid}`}
aria-label={goToParentMessage}
title={goToParentMessage}
onClick={(e) => this.scrollToParent(e)}
>
{' '}
<svg width="7" height="11" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 7 11" aria-hidden>
<path
fill="currentColor"
d="M.815 5.905L2.915 4v7H4.08V4l2.105 1.905.815-.74-3.5-3.17L0 5.165l.815.74zM0 1.045h7V0H0v1.045z"
/>
</svg>
</a>
)}

Expand Down
1 change: 0 additions & 1 deletion frontend/apps/remark42/app/components/comment/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import './__body/comment__body.css';

import './__info/comment__info.css';
import './__input/comment__input.css';
import './__link-to-parent/comment__link-to-parent.css';
import './__status/comment__status.css';
import './__text/comment__text.css';
import './__time/comment__time.css';
Expand Down
1 change: 1 addition & 0 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"scripts": {
"prepare": "if [ -z \"$CI\" ]; then cd .. && husky install frontend/.husky; else echo \"Skip Husky Hooks\"; fi",
"lint-staged": "lint-staged",
"dev:remark42": "turbo run dev --filter=@remark42/app",
"test:api": "turbo run test --filter=@remark42/api",
"coverage:api": "turbo run coverage --filter=@remark42/api",
"type-check:api": "turbo run type-check --filter=@remark42/api",
Expand Down