Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New row is added in tQ without an ID #578

Closed
elsylambert opened this issue Nov 15, 2023 · 3 comments
Closed

New row is added in tQ without an ID #578

elsylambert opened this issue Nov 15, 2023 · 3 comments
Assignees

Comments

@elsylambert
Copy link
Contributor

elsylambert commented Nov 15, 2023

As reported in #563, IDs are not generated in TQs for new rows and if user leaves the ID empty, the new row is added with the ID.

Private Zenhub Image

@elsylambert elsylambert added the bug Something isn't working label Nov 15, 2023
This was referenced Nov 15, 2023
@kintsoogi kintsoogi self-assigned this Nov 16, 2023
@kintsoogi
Copy link
Contributor

@danielklapp @elsylambert

This fix is ready in develop now!

Describe what your pull request addresses (Please include relevant issue numbers):

Please include detailed Test instructions for your pull request:

  • Deploy Preview
  • Navigate to Titus 1:1 on Test_Org En (I input a wrong TSV Item)
    • Click the add button on TN
    • Verify that app does not crash
  • Navigate to a different verse than the one you started on and click add button
    • Verify that the reference column is filled in with the correct verse!
  • Click the add button in TN, TQ, and TWL to verify that random IDs are being generated for each resource

@danielklapp
Copy link

Seeing IDs being generated in TQs for newly added rows. Tested with v2.1.0 build 65fd995 QA.
Screenshot 2023-11-17 at 4 33 01 AM

@elsylambert
Copy link
Contributor Author

v2.1.0 build 19c7052 QA, Add row in tQ looks good.

I have reported Add New Row Bug in TN in #588 @kintsoogi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants