Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripture-tsv version for add TSV bugfixes #584

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

kintsoogi
Copy link
Contributor

@kintsoogi kintsoogi commented Nov 16, 2023

Describe what your pull request addresses (Please include relevant issue numbers):

Please include detailed Test instructions for your pull request:

  • Deploy Preview
  • Navigate to Titus 1:1 on Test_Org En (I input a wrong TSV Item)
    • Click the add button on TN
    • Verify that app does not crash
  • Navigate to a different verse than the one you started on and click add button
    • Verify that the reference column is filled in with the correct verse!
  • Click the add button in TN, TQ, and TWL to verify that random IDs are being generated for each resource

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f845565) 50.22% compared to head (a696640) 51.42%.

❗ Current head a696640 differs from pull request most recent head 88e4c5b. Consider uploading reports for the commit 88e4c5b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #584      +/-   ##
===========================================
+ Coverage    50.22%   51.42%   +1.20%     
===========================================
  Files           43       43              
  Lines         1330     1330              
===========================================
+ Hits           668      684      +16     
+ Misses         662      646      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kintsoogi kintsoogi force-pushed the bugfix-kintsoogi-577-validateTsvs branch from a696640 to 88e4c5b Compare November 16, 2023 19:25
@kintsoogi kintsoogi changed the title Beta update of scripture tsv for deploy preview Update scripture-tsv version for add TSV bugfixes Nov 16, 2023
@kintsoogi kintsoogi marked this pull request as ready for review November 16, 2023 19:26
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhotoNomad0 PhotoNomad0 merged commit 65fd995 into develop Nov 16, 2023
5 of 6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix-kintsoogi-577-validateTsvs branch November 16, 2023 19:28
PhotoNomad0 added a commit that referenced this pull request Dec 6, 2023
* Replace hard coded card names in merge dialog to resource titles

* Replace BranchMergerContext with state in app context

* Update single-scripture-rcl version for #546 (#558)

* Update issue templates

* Add button to TSV Resource Cards to Add another TSV resource

* Moved add button in TWL to actions column in table

* Feature 559 / support front matter (#561)

* added front to demo

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* add error message handling

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Save to DCS on TSV Add & Navigate to new TSV Row (#571)

* Changes to save new TSV row to DCS on add

* Changes to navigate to newly created tsv row

* Only generate Tsv data if resource is tsv

* Change const, clarify ternary, update scrip-tsv version

* feature 524 / added alignment reset and multi-select. (#576)

* added alignment reset and multi-select.

* update dependencies

* update dependencies

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Update version of scripture-tsv to 0.2.1 (#584)

* Fix for 500 errors (#583)

Updated versions of gitea-react-toolkit and single-scripture-rcl

Co-authored-by: PhotoNomad0 <[email protected]>

* Feature kintsoogi 484 delete tsv (#587)

* Add delete tsv functionality and pure setItemIndex

* Small fix for newQuote

* update dependencies

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* upgrades translation-helps-rcl to 3.5.13

* Display add button in header for TWL when no items (#597)

- Display add button in header for TWL when no items
- Do not display delete button if no items in tsv resource card

* Updated version of scripture-resources-rcl

Fixes problem where empty last tsv item in book throws errors

* fixes build error while building with node >= 18

__This is a temporary fix__

Any machine building with node >= 18 runs into this issue:
unfoldingWord/translation-helps-rcl#121

I've modified the build scripts to use the set-env.sh scripts
to determine what the NODE_OPTIONS should be when building.

* Bump version to 2.2.0

* qaFail 602 / Save button is enabled when edit box is clicked (#608)

update single-scripture-rcl

* Bugfix 570 / Fix highlighting errors with right quote in Greek Word (#604)

fixes for highlighting right quotes in original languages

---------

Co-authored-by: kintsoogi <[email protected]>
Co-authored-by: Kintsoogi <[email protected]>
Co-authored-by: elsylambert <[email protected]>
Co-authored-by: PhotoNomad0 <[email protected]>
Co-authored-by: Noah Harvey <[email protected]>
Co-authored-by: Noah Harvey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants