htable: use precalculated list of primes #3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3739 +/- ##
=======================================
Coverage 82.99% 82.99%
=======================================
Files 226 226
Lines 55039 55050 +11
=======================================
+ Hits 45680 45691 +11
Misses 9359 9359
☔ View full report in Codecov by Sentry. |
|
See https://github.com/universal-ctags/ctags/blob/master/extra-cmds/utiltest.c. "make tutil" is the way to run the test. |
masatake
approved these changes
May 30, 2023
masatake
approved these changes
May 31, 2023
|
Thank you. |
|
You're welcome! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like it should work, @masatake -- what's a good way to test this code? There seem to be no unit tests for this.