Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main,refactor: move field null string literals to header. #3740

Merged
merged 1 commit into from
May 31, 2023

Conversation

dtikhonov
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b3e1ad7) 82.99% compared to head (072635d) 82.99%.

❗ Current head 072635d differs from pull request most recent head 5b4b691. Consider uploading reports for the commit 5b4b691 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3740   +/-   ##
=======================================
  Coverage   82.99%   82.99%           
=======================================
  Files         226      226           
  Lines       55039    55050   +11     
=======================================
+ Hits        45680    45691   +11     
  Misses       9359     9359           
Impacted Files Coverage Δ
main/field.c 92.59% <ø> (ø)
main/fmt.c 86.74% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masatake
Copy link
Member

Thank you. you've been active. So I would like to write some rules I introduced during you were absent.

Your change is not about a specific parser. In that case, could you add "main" to the prefix of the commit header? It implies the change has an impact on the whole of the ctags.

If the change is just for code transformation, and if not intended to change the command behavior, use "refactor" (as you already did). You can combine some of the with a comma character.

So the header of your commit log should be: main,refactor: move field null string literals to header.

If your change is about a parser, use the name of parser as the prefix.

See also https://docs.ctags.io/en/latest/contributions.html#committing-and-submitting-a-pull-request

main/field.h Outdated
@@ -79,6 +79,9 @@ typedef enum eFieldDataType {
FIELDTYPE_END_MARKER = 1 << 3,
} fieldDataType;

#define FIELD_NULL_LETTER_CHAR '-'
#define FIELD_NULL_LETTER_STRING "-"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

field.h is visible to parsers.

fmt.c is a part of the main part. So let's put the definition to field_p.h.
The _p.h files are private to the main part.

@dtikhonov dtikhonov changed the title Small refactor: move field null string literals to header main,refactor: move field null string literals to header. May 31, 2023
@dtikhonov dtikhonov requested a review from masatake May 31, 2023 02:22
@masatake
Copy link
Member

Let's squash the two commits into one and update the commit log.
IF you don't know how to do it, I can explain. Let me know.

@dtikhonov
Copy link
Member Author

I always squash merges to master (see, for example, #3739), but here you go.

@dtikhonov dtikhonov merged commit 100a7c2 into universal-ctags:master May 31, 2023
@masatake
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants