Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation's ComputeFromValue is not working correctly #11896

Closed
MartinZikmund opened this issue Apr 4, 2023 · 4 comments · Fixed by #11859
Closed

Animation's ComputeFromValue is not working correctly #11896

MartinZikmund opened this issue Apr 4, 2023 · 4 comments · Fixed by #11859
Assignees
Labels
kind/bug Something isn't working project/animations 🎡 Categorizes an issue or PR as relevant to animations

Comments

@MartinZikmund
Copy link
Member

MartinZikmund commented Apr 4, 2023

Current behavior

The Expander style in WinUI has the following in CheckedPointerOver VisualState:

  <contract7NotPresent:DoubleAnimation
      Storyboard.TargetName="ExpandCollapseChevronRotateTransform"
      Storyboard.TargetProperty="Angle"
      To="180.0" Duration="0:0:0.1"/>

However, the same is in the Checked VisualState to accomodate for keyboard navigation. When the animation finishes, the final value is kept, so subsequent pointer hover should not cause further animation (as the effective From value is already 180.0). However, in case of Uno, the chevron snaps to angle 0 and rotates quickly.

Expected behavior

No animation should occur on poitner over.

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

Our current workaround in Expander_themeresources.xaml was to replace all ocurrences of Duration="0:0:0.1" by Duration="0:0:0". Revert this workaround to see the broken behavior.

Works on UWP/WinUI

Yes

Environment

Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia, Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia

NuGet package version(s)

No response

Affected platforms

No response

IDE

Visual Studio 2022

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@MartinZikmund MartinZikmund added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. project/animations 🎡 Categorizes an issue or PR as relevant to animations and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Apr 4, 2023
@MartinZikmund
Copy link
Member Author

@dr1rrb assigned this one to you, maybe it was reported in some other form before

@jeromelaban
Copy link
Member

@MartinZikmund nice. Is it related to the expander chevron ?

@MartinZikmund
Copy link
Member Author

@MartinZikmund nice. Is it related to the expander chevron ?

Yes, exactly. For now I worked around it by removing the animation

@dr1rrb
Copy link
Member

dr1rrb commented Apr 5, 2023

@Xiaoy312 is it something you are currently working on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working project/animations 🎡 Categorizes an issue or PR as relevant to animations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants