-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(animation): not defaulting starting value from animated value #11859
fix(animation): not defaulting starting value from animated value #11859
Conversation
todo:
|
The build 74080 found UI Test snapshots differences: Details
|
a96cda0
to
60537a3
Compare
The build 74533 found UI Test snapshots differences: Details
|
935bf24
to
67d048e
Compare
67d048e
to
64c4ffc
Compare
src/Uno.UI/UI/Xaml/Media/Animation/Animators/AnimatorFactory.Android.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Media_Animation/Given_DoubleAnimation.cs
Outdated
Show resolved
Hide resolved
64c4ffc
to
625e055
Compare
625e055
to
2c2686d
Compare
c6fc041
to
ceaab79
Compare
The build 75194 found UI Test snapshots differences: Details
|
ceaab79
to
889c277
Compare
The build 75217 found UI Test snapshots differences: Details
|
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Media_Animation/Given_DoubleAnimation.cs
Show resolved
Hide resolved
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Media_Animation/Given_DoubleAnimation.cs
Show resolved
Hide resolved
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Media_Animation/Given_DoubleAnimation.cs
Outdated
Show resolved
Hide resolved
889c277
to
cbbd43d
Compare
The build 75309 found UI Test snapshots differences: Details
|
@jeromelaban could this be backported to uno 4.8 please? |
GitHub Issue (If applicable):
ComputeFromValue
is not working correctly #11896PR Type
What is the current behavior?
Currently animations with omitted
From
infers their starting value from the non-animated value.On windows, you are allow to starting a new animation from the animated value, be mid animation or the
HoldEnd
value of a completed animation.What is the new behavior?
Aligned behavior with windows:
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.