Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bumped shade plugin, fixed clip launch crashing #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 2 additions & 22 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<artifactId>monsterjam</artifactId>
<packaging>jar</packaging>
<name>MonsterJam</name>
<version>8.0-b18</version>
<version>8.1-b18</version>

<repositories>
<repository>
Expand Down Expand Up @@ -118,7 +118,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>3.3.0</version>
<version>3.6.0</version>
<executions>
<execution>
<phase>package</phase>
Expand Down Expand Up @@ -159,25 +159,6 @@
</configuration>
</plugin>

<plugin>
<groupId>com.coderplus.maven.plugins</groupId>
<artifactId>copy-rename-maven-plugin</artifactId>
<version>1.0.1</version>
<executions>
<execution>
<id>rename-file</id>
<phase>install</phase>
<goals>
<goal>copy</goal>
</goals>
<configuration>
<sourceFile>${project.build.directory}/${project.build.finalName}.jar</sourceFile>
<destinationFile>${project.build.directory}/MonsterJam.bwextension</destinationFile>
</configuration>
</execution>
</executions>
</plugin>

<plugin>
<groupId>com.coderplus.maven.plugins</groupId>
<artifactId>copy-rename-maven-plugin</artifactId>
Expand Down Expand Up @@ -222,4 +203,3 @@
</build>

</project>

Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ trait ClipMatrix:
// Util.println(s"lenient calc: $qString $beat $qSize ${beat % (qSize * 4)}")
Util.println(s"lenient calc: $clipQString $qString $prev $now $next")
if prev < launchTolerance || (lookAhead > 0 && next < lookAhead) then
Some(clipQString, "continue_immediately")
Some(clipQString, "continue_or_from_start")
Copy link
Owner

@unthingable unthingable Jun 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, is it just me or Bitwig quietly broke this in an existing API version?

else None
end launchOptions

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,15 @@ public static int convertColor(final SettableColorValue color) {
return convertColorX(color.red(), color.green(), color.blue());
}

/*
public static int convertColor(final BitWigColor color) {
final Integer colorIndex = fixedColorTable.get(color.getLookupIndex());
if (colorIndex != null) {
return colorIndex.intValue();
}
return 68;
}
}
*/

public static boolean isOff(final SettableColorValue color) {
return color.green() == 0 && color.red() == 0 && color.blue() == 0;
Expand Down