Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to JSON Schema Generation #828

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Conversation

david-waltermire
Copy link
Contributor

@david-waltermire david-waltermire commented Feb 11, 2021

Committer Notes

This commit fixes duplicate definition ids in the generated JSON schema which based on metaschema fixes in PR usnistgov/metaschema#116 (issues usnistgov/metaschema#18 and usnistgov/metaschema#113).

Also fixes YAML content conversion.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@david-waltermire david-waltermire merged commit d92fa4f into master Feb 11, 2021
@david-waltermire david-waltermire deleted the int-json-schemagen-fixes branch February 11, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve names of definitions in JSON Schema
1 participant