Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Documentation. #277

Merged
merged 43 commits into from
Jul 26, 2023
Merged

Updated Documentation. #277

merged 43 commits into from
Jul 26, 2023

Conversation

faisalill
Copy link
Contributor

@faisalill faisalill commented May 27, 2023 •
edited
Loading

@abnegate

What's changed:

  1. Added the code to connect to different adapters that are allowed.
  2. Added Database, Attributes, Index, relationship and document methods.

faisalill and others added 22 commits May 21, 2023 02:40
@faisalill
added getCollectionSize method for mysql mariadb postgres and mongodb…
363a2f0 
… adapter
@faisalill
added test
880d3cb
@faisalill
fixed stuff
3f6bdef
@faisalill
better error
b47e34e
@faisalill
Merge pull request #1 from faisalill/get-collection-size
962db9b 
added getCollectionSize method.
@faisalill
same README.md
86765f3
@faisalill
better readme until create a collection
759795e
@faisalill
fixed stuff
00554b1
@faisalill
better readme until documents, added try catch blocks for few
851463f
@faisalill
better readme, document and relations methods pending
cee14f3
@faisalill
readme finished
706d64c
@faisalill
finished tests
639cc68
@faisalill
fixed stuff
8866b97
@faisalill
removed try catch
d911321
@faisalill
added more methods
aa1107e
@faisalill
removed readme
8dedb45
@faisalill
added readme
763e8a4
@faisalill
removed collection size
9fc188a
@faisalill
Merge branch 'utopia-php:main' into better-readme
9e933b6
@faisalill
remove templates
63c84f9
@faisalill
added readme
14d7e7f
@faisalill
better readme
85ec5ce
abnegate
abnegate reviewed May 29, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@faisalill
Copy link
Contributor Author

faisalill commented May 30, 2023 •
edited
Loading

@abnegate,
Did the changes as you mentioned.

abnegate
abnegate reviewed May 30, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@faisalill
Copy link
Contributor Author

@abnegate ,
Did the changes as you said.

@stnguyen90 stnguyen90 self-requested a review July 17, 2023 18:47
stnguyen90
stnguyen90 requested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 I left some comments during the review, please check them out.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@gewenyu99
Copy link

I have no comments beyond what has been mentioned by Steven. Great PR!

@faisalill
Improve Navigation and Enhance the documentation
1c9dfc0 
Add Table of contents for readme.md and contributing.md

Update limitations for mariadb,mysql,postgres,sqlite and mongodb

Add tests in contributing.md

Add contributing section in readme.md

Fix code as per review from steven
stnguyen90
stnguyen90 requested changes Jul 18, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@faisalill
Remove table of contents and Enhance the readme and contributing.md
e5a5849 
Remove table of contents from readme.md and contributing.md

Change supported databases table from horizontal to vertical.

Fix improper headings and title cases
@faisalill
Fix Indentation and Remove colon from headings
0d10f7d
stnguyen90
stnguyen90 reviewed Jul 22, 2023
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 1 comment: #277 (comment)

Otherwise, this looks beautiful!

@faisalill faisalill requested a review from abnegate July 22, 2023 15:42
abnegate
abnegate reviewed Jul 25, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@faisalill faisalill requested a review from abnegate July 26, 2023 02:05
abnegate
abnegate reviewed Jul 26, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@abnegate abnegate requested a review from stnguyen90 July 26, 2023 19:01
@abnegate abnegate merged commit 540ec7e into utopia-php:main Jul 26, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

@abnegate abnegate abnegate approved these changes

@adityaoberai adityaoberai Awaiting requested review from adityaoberai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@faisalill @gewenyu99 @stnguyen90 @abnegate @adityaoberai