-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chained container proxies configuration refactor #8658
base: master
Are you sure you want to change the base?
Chained container proxies configuration refactor #8658
Conversation
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
Suggested tests to cover this Pull Request
|
b43e928
to
d945e30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d945e30
to
fb03d2f
Compare
java/spacewalk-java.changes.rjpmestre.chained_container_proxies_configuration_refactor
Outdated
Show resolved
Hide resolved
a7dfe4b
to
643e87e
Compare
4cbfdd2
to
95fc81b
Compare
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for the refactor @rjpmestre
Also related: https://github.com/SUSE/spacewalk/issues/24680
95fc81b
to
5988fa7
Compare
5988fa7
to
7bd48ac
Compare
What does this PR change?
Introduces the Chain of Responsibility pattern to streamline the creation of a proxy container configuration file. This enhances code readability as we extracted a portion of code from the SystemManager class (which was dedicated to this flow) and relocated it into a dedicated structures with clear and defined steps. Additionally, it also improves testability as each step has a narrow scope.
GUI diff
No difference.
Documentation
No documentation needed: we commented each object/step with their purpose
DONE
Test coverage
No tests: already covered
DONE
Links
Related:
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!