feat: add method to customize Dialog overlay ARIA role #6473
Conversation
|
|
This ticket/PR has been released with Vaadin 24.5.0.alpha7 and is also targeting the upcoming stable 24.5.0 version. |
| * @param role | ||
| * the role to set | ||
| */ | ||
| public void setOverlayRole(String role) { |
There was a problem hiding this comment.
I'm wondering if this should be an enum on the flow side with both possible values (dialog / alertdialog) to ensure the typical type safety on java side.. those values don't change often and people could theoretically always use the element API if a new value comes out of the blue and you could not update in time.
There was a problem hiding this comment.
Good point. Maybe we could add an override for this method to Dialog and also Popover.
There was a problem hiding this comment.
That you have to decide :) While in alpha.. I would just ditch the old methods completely before you have to maintain them for decades
There was a problem hiding this comment.
We are about to release beta so I'm afraid for now we'd have to leave these methods as they are.
Created #6645 so that we don't forget about this idea, and maybe consider it for the next minor.
Description
Part of vaadin/web-components#4977
Depends on vaadin/web-components#7582
Added
setOverlayRole()andgetOverlayRole()methods toDialog(the logic is copied from thePopover).Type of change